Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp4037345ybn; Fri, 27 Sep 2019 15:24:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqxJBFrkjOTOHtoI9BpTj0XSSiQl7LfFj3TIegzVUnfJTuSAtAgDhMryfM4PKRRSaCSJaCdS X-Received: by 2002:a17:906:c4b:: with SMTP id t11mr9799029ejf.131.1569623083971; Fri, 27 Sep 2019 15:24:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569623083; cv=none; d=google.com; s=arc-20160816; b=DbyJESFV1GRfKhj6wqYES3hwJctpitgIKsvecrIh8i/JyqVIc2VWO9ya8vin1oobn2 fzLGiaAhE+6XxSIzd9ZB16dBzzIE5ttciq/0fa1tH1a9/uSLJfAUdBuBK6NtZ9e6q5JR OAL2brXNqITXyrShmzuIzp87RdYPjIdNGlAtErDZUYmkST1KxmyXFhkq9V9ZuZWSRXOq kQ8PG5IL9EQha14yZOVB5SIUl7miKHytzQhlPOQDU4vQ2UdJNr4xIoIOSAQHJmNusK/U BpXwblQA9gm0bGT4iVqQWgbS2sFM5R4xaErJU1jzbA5SQ4qUtEzi8Xl4jC/+FaKX4O18 WVXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GMhX4IEoEZR9fDA9m6gHVRHcmk8xst8oXUoqv2OMAvg=; b=K3nfS5l1DWF/W1NzyyFRjJoXbxkb3SYg8D1oIWXh5cFPW0uQhwF0XvB2NF+W3wxgzq qNwflr5AU1wnoJABHtGZb+jrojNC2aEkWYFk1dgiO0GTCFBwk99OsVb0NePLM72osS9w nWmXqrH4FMvyx/CtsL8y+F/6uulmKYFFZW5xCaHgHJ1BPucDThbvnr6W+/l7CYo8/3Oa tFe+6aGgnLq1pWp0GHu1l7QykybUgkzB5rxWA5kSa+KKynDVEvC8UIUPRZ322glKs5/C Jt8BJufgASJrbG1incW9UjhDRzndjRbzeKguCIDpPgnFzUwy2XLibSPhwpnBW7hMt+V6 k+OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=K72cvBVJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gq15si3534294ejb.209.2019.09.27.15.24.19; Fri, 27 Sep 2019 15:24:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=K72cvBVJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbfI0WYE (ORCPT + 99 others); Fri, 27 Sep 2019 18:24:04 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46716 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfI0WYE (ORCPT ); Fri, 27 Sep 2019 18:24:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GMhX4IEoEZR9fDA9m6gHVRHcmk8xst8oXUoqv2OMAvg=; b=K72cvBVJzl9f+bC8V1PYsT6Mb 3pKPyNaRzzzDUdowci+OV8ukpD6sul3R/F/rzYeygI87BXkyhogbMGO98D3BERCQ6mD92guPxeZBu ir8kfaJIP2LHYv4vy5mrlpQvIKDfv97JVskFSIB9uCyMq6K29FSJZt0q8I2/5WuM4fB30R2LSmISX 0e+NRCTWq+Gkprf6GczgyCTobPHWgfRrrulJaOIfnZNsZ429GYkKByUfyAosXdqJsk3qwvslEZUZl CXAUGQQKS/+un4VSOGEl1K03mzWEb4COwoqsglrM0i504ROgy6EzgU2mPxkmiLGlvnnrdxEXsuxPz 1r38Lkdqw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDyef-0002wN-2O; Fri, 27 Sep 2019 22:24:01 +0000 Date: Fri, 27 Sep 2019 15:24:01 -0700 From: Christoph Hellwig To: Palmer Dabbelt Cc: linux-riscv@lists.infradead.org, mark.rutland@arm.com, me@carlosedp.com, linux-kernel@vger.kernel.org, joel@sing.id.au, marco@decred.org Subject: Re: [PATCH] RISC-V: Clear load reservations while restoring hart contexts Message-ID: <20190927222401.GE4700@infradead.org> References: <20190925001556.12827-1-palmer@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925001556.12827-1-palmer@sifive.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 24, 2019 at 05:15:56PM -0700, Palmer Dabbelt wrote: > This is almost entirely a comment. The bug is unlikely to manifest on > existing hardware because there is a timeout on load reservations, but > manifests on QEMU because there is no timeout. Given how many different lines of RISC-V hardware are around how do you know it doesn't affect any existing hardware? Except for that the patch looks fine to me: Reviewed-by: Christoph Hellwig