Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: aIylKq8+GXLkQ5nDQ36HEjnm4UKdNrxwwBv2cwa4NPeKh6zTJh/jcwfe0dQSwUJ7npg9bMLRQf
 NuhH1N3eDmfagmJwwAT/tyR2xVa7GnFVspmiVbX93dnsEuY0en7ubPpxVpAv4hN0VEyE6lNVad
 MdlbO39qYFDVJ44d6dT1ieL8wY3WK3gLaTMsvglK46CA4F+WRFY6AtiBzUuaedk0w8EKQCnfde
 +LmPm3lGPgH02APJvAJJdmRG7boQvX9ALrqAVtjuwGiZdnorapU9WaJ9C80xp01QM60gYu37td
 3hA=
IronPort-PHdr: =?us-ascii?q?9a23=3Am8qV7xxaep0HkbvXCy+O+j09IxM/srCxBDY+r6?=
 =?us-ascii?q?Qd1OMXIJqq85mqBkHD//Il1AaPAdyArakbwLGP+4nbGkU4qa6bt34DdJEeHz?=
 =?us-ascii?q?Qksu4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPER?=
 =?us-ascii?q?vjKwV1Ov71GonPhMiryuy+4ZLebxhGiTanb75/Lhq6oAvMusILnYZsN6E9xw?=
 =?us-ascii?q?fTrHBVYepW32RoJVySnxb4+Mi9+YNo/jpTtfw86cNOSL32cKskQ7NWCjQmKH?=
 =?us-ascii?q?0169bwtRbfVwuP52ATXXsQnxFVHgXK9hD6XpP2sivnqupw3TSRMMPqQbwoXz?=
 =?us-ascii?q?mp8rxmQwH0higZKzE58XnXis1ug6JdvBKhvAF0z4rNbI2IKPZyYqbRcNUfRW?=
 =?us-ascii?q?pARcZRTC1BAoWzb4ASEeQPJPtTr4f8p1QQqRuxGBSnCOfhxzNUg3P727Ax3e?=
 =?us-ascii?q?Y8HgHcxAEuH8wAvmnaotv2M6kfSvy5wLXSwDnfdf5axSvx5Y7VeR4hu/GMWr?=
 =?us-ascii?q?dwfNLTxkkuFgLFjkiQqYv4ND6S1uUMsmib4PBhVe6zl2IqpRp8oiWzycc2kI?=
 =?us-ascii?q?XGmJ8ayk3d+Ch/3Y07JsW4RVZlbdK4FJZcrSKXOotsTs88Xm1kpDw2xqMatZ?=
 =?us-ascii?q?KnZCQG1ZUqyhrFZ/CZfYWF4gjvWPiQLDtihn9od7SyjAuo/0e60O3zTMy03U?=
 =?us-ascii?q?5PripCj9bDqGgA1wfW6sibUvt9+Vqh2SqX2wDT9O5EJUc0mLLeK5E7w74wko?=
 =?us-ascii?q?MfsVzNHiPrgUn2grGaelk49uSy5OTnZbLmppCYN4BqkA3xLqMumsmnDeQ5NA?=
 =?us-ascii?q?gBQXSb9Pyi2LH/+UD1WrZHg/0snqXHrZzWOd4XqrClDwNJyooj7gywDzai0N?=
 =?us-ascii?q?QWh3kHK1dFdQqHjonoO1HBOvH4Aeujj1miizpr2uzJPqf7DprTM3fDja/tfa?=
 =?us-ascii?q?xh5E5E1Aoz0ddf6opQCrEAJvLzR0DwuMXbDhAnKQy0xfjoCNFm24MAVmKAHL?=
 =?us-ascii?q?WZPLnRsVCW/OIvJfeDZIsPtDb6Mfgl6K2mo2U+nAosfLupwJxfPGGqHv1nex?=
 =?us-ascii?q?3CSWfnmJEMHXpc7Vl2d/DjlFDXCW0bXH21Ra9po25jBQ=3D=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Enrico Weigelt <info@metux.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] iio: adc: imx25-gcq: Variable could be uninitialized if regmap_read() fails
Date:   Fri, 27 Sep 2019 17:28:51 -0700
Message-Id: <20190928002852.28329-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function mx25_gcq_irq(), local variable "stats" could
be uninitialized if function regmap_read() returns -EINVAL.
However, this value is used in if statement, which is
potentially unsafe. The same case applied to the variable
"data" in function mx25_gcq_get_raw_value() in the same file.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/iio/adc/fsl-imx25-gcq.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index df19ecae52f7..dbf3e8e85aba 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -74,7 +74,10 @@ static irqreturn_t mx25_gcq_irq(int irq, void *data)
 	struct mx25_gcq_priv *priv = data;
 	u32 stats;
 
-	regmap_read(priv->regs, MX25_ADCQ_SR, &stats);
+	int ret = regmap_read(priv->regs, MX25_ADCQ_SR, &stats);
+
+	if (ret)
+		return ret;
 
 	if (stats & MX25_ADCQ_SR_EOQ) {
 		regmap_update_bits(priv->regs, MX25_ADCQ_MR,
@@ -121,7 +124,10 @@ static int mx25_gcq_get_raw_value(struct device *dev,
 		return -ETIMEDOUT;
 	}
 
-	regmap_read(priv->regs, MX25_ADCQ_FIFO, &data);
+	int ret = regmap_read(priv->regs, MX25_ADCQ_FIFO, &data);
+
+	if (ret)
+		return ret;
 
 	*val = MX25_ADCQ_FIFO_DATA(data);
 
-- 
2.17.1