Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 28 Sep 2019 17:25:07 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Ivan Safonov <insafonov@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] genirq: replace notify with old_notify in
 irq_set_affinity_notifier()
Message-ID: <20190928172507.6698545f@oasis.local.home>
In-Reply-To: <20190928151921.29268-1-insafonov@gmail.com>
References: <20190928151921.29268-1-insafonov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 28 Sep 2019 18:19:20 +0300
Ivan Safonov <insafonov@gmail.com> wrote:

> This patch is for Linux 4.19 with a RT patch.
> 
> The second 'if' block does not check notify for NULL,
> this leads to a system crash.
> 
> Most likely, there is a typo here.
> 
> With old_notify system works as expected.
> 
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
> ---
>  kernel/irq/manage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 290cd520dba1..79a7072dfb3c 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -412,7 +412,7 @@ irq_set_affinity_notifier(unsigned int irq, struct irq_affinity_notify *notify)
>  
>  	if (old_notify) {
>  #ifdef CONFIG_PREEMPT_RT_BASE
> -		kthread_cancel_work_sync(&notify->work);
> +		kthread_cancel_work_sync(&old_notify->work);

Thanks for the patch, but I currently have an RFC out that rewrites all
this code. I'm hoping to apply the RFC patch next week.

-- Steve


>  #else
>  		cancel_work_sync(&old_notify->work);
>  #endif