Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <b7fbe8776703b9d637ab82ad4724353b359f1d04.1569555841.git.baolin.wang@linaro.org>
 <20190927184548.312AA20872@mail.kernel.org>
In-Reply-To: <20190927184548.312AA20872@mail.kernel.org>
From:   Baolin Wang <baolin.wang@linaro.org>
Date:   Sun, 29 Sep 2019 10:30:31 +0800
Message-ID: <CAMz4kuJ6S4NfhGk=jQiha+xbuke441Lp5FBSjsgO=2GY=6S5eQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value
 of syscon_regmap_lookup_by_phandle()
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Stephen,

On Sat, 28 Sep 2019 at 02:45, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Baolin Wang (2019-09-26 20:50:53)
> > The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
> > IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().
> >
> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> > ---
> >  drivers/clk/sprd/common.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixes tag?

Yes, the fixes tag should be:
Fixes: d41f59fd92f2 ("clk: sprd: Add common infrastructure")

Do I need to resend this patch with adding the fixes tag?

-- 
Baolin Wang
Best Regards