Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp5853198ybn; Sun, 29 Sep 2019 07:06:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyHxXqkxDeOsNQk+c/ZaTDhOGtvUnOpcRqGOwX4X/zPkWsUHNoE60o9HUyztyXPN2hNBf5 X-Received: by 2002:a17:906:c82d:: with SMTP id dd13mr4739515ejb.169.1569765998265; Sun, 29 Sep 2019 07:06:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569765998; cv=none; d=google.com; s=arc-20160816; b=ia3MeZtuDPIUk4aiAajSr2bVMdu1RsNHi0dmNqzqItqq1r5rtjXYPt97ld7BUhsS3e WK68UlVeocEZSusakv1PhvtVpWHB/8yFtDas0kcCZDl+/4TPJje/vwhS0gxVkt5HOe7x M6OpgGH/rYSSiOd/9pST42J8ZMoJ83uy6gpUQIsdB4f4BA+jhWqW4wPcZTMoWeJ3mDiQ ZQD+jeaiysjLDztC5eNBTAldh6+H6/9KUS+7bb08NtKHbk+ll8RqrOnY7rXOmyvu2wKm rVe3V6vgPj6s2gf3ExbHFdZvG98RlkXlsZYvT+LObGsp+IY/CDQJZs+3B7bSK0fzD/H0 +LLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5GO+bCFJVlLRPV9lBFSbUoF8jhRh8Qvn+KSJbd4iKp4=; b=kze4KQEExRooLu2/kWttjlwb4dNlwHik5DaozInZgPciD1mNu/xAOTuK1uXh9+a2aw 7urKCPg1H3PhykvmAy3sREbtnagLpBvHVBkjXHS3HseYbmdjRqySciOwbi6gWbdJ2qLK JmSPc7dJoK7e8T14gfn4+fmul/ztsVB2T34mobEEBgzmEhTiuN2oNX9ycH/IdXZrwmYY v0D09Vgkd0deLe/7gF075kOLDuGnxld1GgaMFS3mXtlCeaWTwSFbHBQwbcA22/ZXDRrj tHrxzXmxnCcVzdvDVDln4EHJnFePrcaua4ukISrONa37Os0aKfB42bqdZUhJbDiUFpV0 JgNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1l9p2Ntc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j52si5464411eda.338.2019.09.29.07.06.13; Sun, 29 Sep 2019 07:06:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1l9p2Ntc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729510AbfI2OBu (ORCPT + 99 others); Sun, 29 Sep 2019 10:01:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:44118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730072AbfI2OBp (ORCPT ); Sun, 29 Sep 2019 10:01:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5A8721835; Sun, 29 Sep 2019 14:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569765705; bh=kIPGBHPBXLNlAwGmoPfJpsWmba/5nJ1VTP4Y2cSafRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1l9p2NtcmG1J75LlLbxOpL8Gad5JY1iRCrXzyZysTfJ08dlt2Ll2yLV0Qm0tvCCq8 9+4BaYJ2eXrM9+4sF4f51ltmjYFUzTAsHyM9TgXJK+NSJ/g+FeWpJ9/2cN4Uww5PDO yP9HsBymDt/tZbgFjIySsKbfPYwF6akezzTTClP0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Filipe=20La=C3=ADns?= , Benjamin Tissoires , Jeremy Cline Subject: [PATCH 5.2 21/45] Revert "HID: logitech-hidpp: add USB PID for a few more supported mice" Date: Sun, 29 Sep 2019 15:55:49 +0200 Message-Id: <20190929135030.591928130@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190929135024.387033930@linuxfoundation.org> References: <20190929135024.387033930@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benjamin Tissoires commit addf3382c47c033e579c9c88f18e36c4e75d806a upstream. This partially reverts commit 27fc32fd9417968a459d43d9a7c50fd423d53eb9. It turns out that the G502 has some issues with hid-logitech-hidpp: when plugging it in, the driver tries to contact it but it fails. So the driver bails out leaving only the mouse event node available. This timeout is problematic as it introduce a delay in the boot, and having only the mouse event node means that the hardware macros keys can not be relayed to the userspace. Filipe and I just gave a shot at the following devices: G403 Wireless (0xC082) G703 (0xC087) G703 Hero (0xC090) G903 (0xC086) G903 Hero (0xC091) G Pro (0xC088) Reverting the devices we are not sure that works flawlessly. Reviewed-by: Filipe LaĆ­ns Signed-off-by: Benjamin Tissoires Signed-off-by: Jeremy Cline Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-logitech-hidpp.c | 20 -------------------- 1 file changed, 20 deletions(-) --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -3749,28 +3749,8 @@ static const struct hid_device_id hidpp_ { L27MHZ_DEVICE(HID_ANY_ID) }, - { /* Logitech G203/Prodigy Gaming Mouse */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC084) }, - { /* Logitech G302 Gaming Mouse */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07F) }, - { /* Logitech G303 Gaming Mouse */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC080) }, - { /* Logitech G400 Gaming Mouse */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07E) }, { /* Logitech G403 Wireless Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) }, - { /* Logitech G403 Gaming Mouse */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC083) }, - { /* Logitech G403 Hero Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08F) }, - { /* Logitech G502 Proteus Core Gaming Mouse */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07D) }, - { /* Logitech G502 Proteus Spectrum Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC332) }, - { /* Logitech G502 Hero Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08B) }, - { /* Logitech G700s Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07C) }, { /* Logitech G703 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) }, { /* Logitech G703 Hero Gaming Mouse over USB */