Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp5866823ybn; Sun, 29 Sep 2019 07:21:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPSDG0JZZahxz9/AxrLlALHEy5bZNJDJSk8vp7XsgefKKEzqjjnOcsKjBOH/ZaR3NnLGiN X-Received: by 2002:a50:fd86:: with SMTP id o6mr14926969edt.139.1569766908156; Sun, 29 Sep 2019 07:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569766908; cv=none; d=google.com; s=arc-20160816; b=hQ3FDV3iwsWsXD68olNmPqqhOt0bx8Ti2DrDpliA0imnwu2YmLYPsybUs/tct3noFd H8YoMlwbNMzPxM2x6uo68n4nhlabPTgrN5KE8FEOSH0PhLA4VsuLnsQVvKhmD8/HgDLP Anf73MHt22UlVmNF94Mw7eGk/qHYGwJUJ7hWxzBiWHAMkwS0lUuo12/ZiqSAbmq8pyjO q0XTQQ2gNagPaAa26UyR0ESuPeaVyKeCtcMGwH1VOjZ+5J/l2e3jHTauURuQxo3aihc/ Zut0fTwoJzakRDGgApun3LCszKocdZykN1t45C/ydoAJNYWSp6alaRm7kRiHZL6mHlFF 8psw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=QjI2UKdBTdDpx4cfmKvkvgj/Fe/s7UCv8NhDMhZZ83Q=; b=i8FCmtnZmxDG8OyOTzNm3+qTYMbzjCwQ3CCrwYWR6Ryu38wq4CFcOYTGntpjNxKF7w L/yEpC3ppKbUVX/kDE0kbpaKeYLrnzssJ+Z3k0lJzo85rWDGo0yzssiVacJGm7ysPSJo BdkW1W+2SECppInLa3jZ36eAQ4EJDtXtCFeNfzSRaSAhWb6EI4Y5U+w6uPBrsMptJmtR 8xMJJBt83Wal5Mi/vi/AAtV6wt4D3HHYa0hdfhm3iwc6HWBpwmQbc0F1Dmd9i5j3q7Wz GIu9jJClAixtN/7PE4pEWPFDByCfM3mIXdlFEIgfJEGNyr+Sir/FEkeBuFwfdUurZeTF kcYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=i7wnqtKF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z42si5263356edz.23.2019.09.29.07.21.23; Sun, 29 Sep 2019 07:21:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=i7wnqtKF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729081AbfI2OU1 (ORCPT + 99 others); Sun, 29 Sep 2019 10:20:27 -0400 Received: from mout.gmx.net ([212.227.17.20]:44323 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfI2OU1 (ORCPT ); Sun, 29 Sep 2019 10:20:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569766813; bh=QjI2UKdBTdDpx4cfmKvkvgj/Fe/s7UCv8NhDMhZZ83Q=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=i7wnqtKFdzLyx0BtJPPZGiShPm6JBNEb+2pEsyxqR1VI1xyJhmekU8vtNBhB9fmFZ oGvygj/tA4L2dTrO5cOXo1M3Oh5dj+Ui5ts03i9/vVA/9w1PuS7S545qrnBBfNI608 a2BtGUmw0qSu7yuWw+i3qT7cjxVH03nXj7G/UUMU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.130]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJmGP-1iYiIv43p3-00KAVg; Sun, 29 Sep 2019 16:20:13 +0200 Subject: Re: [PATCH RFC V2] nl80211: Fix init of cfg80211 channel definition To: Johannes Berg Cc: Alexei Avshalom Lazar , "David S. Miller" , Dmitry Osipenko , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1569766379-9516-1-git-send-email-wahrenst@gmx.net> From: Stefan Wahren Message-ID: <560d7cb0-b509-6f2a-f31a-1743131e14df@gmx.net> Date: Sun, 29 Sep 2019 16:20:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1569766379-9516-1-git-send-email-wahrenst@gmx.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:E+Gc2cS4gkyzLOB29obc3xQlu0XoQVRGJvunw+VypChp4pm/K3D YuUgzyjCQBqfS4HIj8paluhlTzX8hfH82fg0Ilr7GtiVI2jv5L94rfcoHdqKn1jfQVdGUTj +UKHxGtpo2E4rKOpdS0rYkVd1FMof12yha5IQo4664pXa+5fXKb8upinEhrqE8qYW8OKIog i2gOv91jqlcso6iZE+0/w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:f7pxAe5sqkQ=:4tM3hg7I9Yh/lnxS3cDqJQ bEE/lgFkxFw1EB8Ll8n5xXU4uGZ80aTUzQovNIR6JG96w6Or3ak4NoMjDie9BjjzyTxV4/CyY CtLYqRCfDANTiNeDfge1QXlFCW3DPOj1HfhtmnXPHJ5HktKzRyNhscRhiUJPbyftR6NH+G8pJ 5SnVj0tbMzcLTxP2xSJ1RBYaW/U0ekB9CJ/jmMpJH3on/4TNSQ3arQUZSYKzfQnZQLxpxY7fv hDx7+o9COROUgGeCuZSRsg7sW4qdFxpzugQzc+qtay8/BhXSq4wNwUx3p07wiowOjqGTnMpyo Tm/jyWnKNYEWv7eicByuV/yPNihn2hfN8FZ7tBlgb7k1xnu2vBPP+EBUoVwNZkTPScJZz3MhX Oep3CVwXhy1f79tWaOoFLV3qjbgHhDhSk6bUVIjJf7aOSgYRGUwMZCwwMeapRU6qrbVcCPmUW KCzP33JjV8VIXBfI9ytCchHpdOZTuU53Wxsv5uGCoK0SS0zM7OUDW9STjKSbpL6o4fkRnIrV5 ouGXEDheF1cz+SkQxIHGVXs4tJKyxixglsYd03Hj1WPn3F52v/BJRYTz1hx5bOc13IyP9ikAx X9/TdxPky1NTLgGu+pAaTqnV5PllAZHKTCYKfM0tUa9GOZiMN0/FuBv2eCMdP1q3uM0UGQQ91 4e20VaAcSF9TOPIaOozYE03baZllf4HwWBWQiyww0Xf08sieOWXpd16PnL8AIvn0aTzte0Kpv PdtIqA8cebx9PjZRJfI5sUBgfIXpKXyyO9+kEOjFBherLZBmMY81ZbTFV9Is6gkqiUJO7U1Un V0dQON21G6lAtaTBcl9GQaMmqVDBEZl+oUNHlcVJQ7+BKViRmDslnMm+B4OejKM+CkxjYn1yC C2E+G30wJWmwufzugkIDWnTt0y67CDTzdytpBio21IsbYwpAFWqt3lDMhRnphsYQ+3RvTjpoX M6e3pW1+nJCeYqkxl3ftdtXAT9AOG7Ao/TAjh4rQLnmsB6CEtLrRXXz4rqhTqT6L8Gc7lYCGb RKOrNwA5kVaa7wsx1yI2jDpoXxwSawRUA/ktUE7WKkq7z9NrrRF+jjqlN11BEzIxHfvg/HRvC KmnHTn7V2TEclEH/COIcPt6d/BBr7l+I2iMCS0T3ueoUKC3HxmsWQ3SbyqbVccu510GgHnAD/ EITgfvHJiMdOU00LPazxwQUQ/beKZ1OqDIiID19arvWFcnji81fBsZTKIhK8ZMltfMwwNBahe YxB0nXZ5ytjlUzFMRvltsqZ9KiPqDjjudFHqlZCcdkBIM4XMOkhv3hs6ikLQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johannes, Am 29.09.19 um 16:12 schrieb Stefan Wahren: > The commit 2a38075cd0be ("nl80211: Add support for EDMG channels") > introduced a member to the cfg80211 channel definition. Unfortunately > the channel definitions are allocated on the stack and are not always > initialized via memset. Now this results in a broken probe of brcmfmac > driver, because cfg80211_chandef_valid() accesses uninitialized memory > and fail. Fix this by init the remaining occurences with memset. > > Reported-by: Dmitry Osipenko > Signed-off-by: Stefan Wahren > Fixes: 2a38075cd0be ("nl80211: Add support for EDMG channels") i oversight your patch. Sorry for the noise.