Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 29 Sep 2019 18:32:12 +0200 (CEST)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Yuehaibing <yuehaibing@huawei.com>
cc:     Gilles Muller <Gilles.Muller@lip6.fr>, nicolas.palix@imag.fr,
        michal.lkml@markovi.net, maennich@google.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        cocci@systeme.lip6.fr
Subject: Re: [RFC PATCH] scripts: Fix coccicheck failed
In-Reply-To: <2c109d6b-45ad-b3ca-1951-bde4dac91d2a@huawei.com>
Message-ID: <alpine.DEB.2.21.1909291810300.3346@hadrien>
References: <20190928094245.45696-1-yuehaibing@huawei.com> <alpine.DEB.2.21.1909280542490.2168@hadrien> <2c109d6b-45ad-b3ca-1951-bde4dac91d2a@huawei.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Sun, 29 Sep 2019, Yuehaibing wrote:

> On 2019/9/28 20:43, Julia Lawall wrote:
> >
> >
> > On Sat, 28 Sep 2019, YueHaibing wrote:
> >
> >> Run make coccicheck, I got this:
> >>
> >> spatch -D patch --no-show-diff --very-quiet --cocci-file
> >>  ./scripts/coccinelle/misc/add_namespace.cocci --dir .
> >>  -I ./arch/x86/include -I ./arch/x86/include/generated
> >>  -I ./include -I ./arch/x86/include/uapi
> >>  -I ./arch/x86/include/generated/uapi -I ./include/uapi
> >>  -I ./include/generated/uapi --include ./include/linux/kconfig.h
> >>  --jobs 192 --chunksize 1
> >>
> >> virtual rule patch not supported
> >> coccicheck failed
> >>
> >> It seems add_namespace.cocci cannot be called in coccicheck.
> >
> > Could you explain the issue better?  Does the current state cause make
> > coccicheck to fail?  Or is it just silently not being called?
>
> Yes, it cause make coccicheck failed like this:
>
> ...
> ./drivers/xen/xenbus/xenbus_comms.c:290:2-8: preceding lock on line 243
> ./fs/fuse/dev.c:1227:2-8: preceding lock on line 1206
> ./fs/fuse/dev.c:1232:3-9: preceding lock on line 1206
> coccicheck failed
> make[1]: *** [coccicheck] Error 255
> make: *** [sub-make] Error 2

Could you set the verbose options to see what the problem is?  Maybe the
problem would be solved by putting virtual report at the top of the rule.
But it might still fail because nothing can happen without a value for the
virtual metavariable ns.

Should the coccinelle directory be only for things that work with make
coccicheck, or for all Coccinelle scripts?

julia