Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 29 Sep 2019 16:15:31 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
        rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org,
        mingo@redhat.com, linux@rasmusvillemoes.dk
Subject: Re: [PATCH] Make is_signed_type() simpler
Message-ID: <20190929161531.727da348@gandalf.local.home>
In-Reply-To: <20190929200619.GA12851@avx2>
References: <20190929200619.GA12851@avx2>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 29 Sep 2019 23:06:19 +0300
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> * Simply compare -1 with 0,
> * Drop unnecessary parenthesis sets
> 
> New macro leaves pointer as "unsigned type" but gives a warning,
> which should be fine because asking whether a pointer is signed is
> strange question.
> 
> I'm not sure what's going on in the i915 driver, it is shipping kernel
> pointers to userspace.

This tells us what the patch does, not why.

-- Steve

> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>