Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <df9fc32955789e7fcd01623433faba8d2f446b6e.camel@surriel.com>
Subject: Re: [PATCH v3 04/10] sched/fair: rework load_balance
From:   Rik van Riel <riel@surriel.com>
To:     Vincent Guittot <vincent.guittot@linaro.org>,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        peterz@infradead.org
Cc:     pauld@redhat.com, valentin.schneider@arm.com,
        srikar@linux.vnet.ibm.com, quentin.perret@arm.com,
        dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com,
        hdanton@sina.com
Date:   Sun, 29 Sep 2019 21:12:52 -0400
In-Reply-To: <1568878421-12301-5-git-send-email-vincent.guittot@linaro.org>
References: <1568878421-12301-1-git-send-email-vincent.guittot@linaro.org>
         <1568878421-12301-5-git-send-email-vincent.guittot@linaro.org>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-2AVNAWhLoNHLiOt8ttgM"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-2AVNAWhLoNHLiOt8ttgM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote:
>=20
> Also the load balance decisions have been consolidated in the 3
> functions
> below after removing the few bypasses and hacks of the current code:
> - update_sd_pick_busiest() select the busiest sched_group.
> - find_busiest_group() checks if there is an imbalance between local
> and
>   busiest group.
> - calculate_imbalance() decides what have to be moved.

I really like the direction this series is going.

However, I suppose I should run these patches for
a few days with some of our test workloads before
I send out an ack for this patch :)

--=20
All Rights Reversed.

--=-2AVNAWhLoNHLiOt8ttgM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl2RVpQACgkQznnekoTE
3oNfggf/WBHfPWe8ErJONlgEHEoT5xpDMS8PsFn+p720AyAAYR7n+U+qfNF4/VWl
UsBOX/dGfDo7XeSI4TmtWwrrcbF0Qr6uyScCRrhRRQ/oB9qfHCyCWRATkEHjBpmQ
YntJJ2fGDfZoRYy189dIcVVdFXDkJK046XwqMTi1NstOQOjMw8drAJp3uLoM7Hn6
RaqEaG1MUMpvIHfW5AMGCHqedIjUXdc4/+YJJBeOTQ7PfOcHP6sGVkeDBCXCnSzB
+KCQk4gEg8Q6uJuEk3L+62MZdzPXcd8U5ERU7we3VN7+BMffHN7QrxD1NseFBWil
nLI2XRqjWZ6tlRCaRSYsKRcXHQJQhw==
=gOeM
-----END PGP SIGNATURE-----

--=-2AVNAWhLoNHLiOt8ttgM--