Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp6563178ybn; Sun, 29 Sep 2019 23:25:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxs/2P9vDEwGBDYHAAtAzPfNrvPOEmbtTKt6C9pNBklBkEDP+B2j6AlyL1GVSZ6DL218/MJ X-Received: by 2002:a17:906:7e56:: with SMTP id z22mr17110585ejr.294.1569824715328; Sun, 29 Sep 2019 23:25:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569824715; cv=none; d=google.com; s=arc-20160816; b=KZFq+rXvmjmN8F0pbgMdaqxBntwEENKp/Uc1Js4f54cc01drAGDsDRteY4AIWQFxuI EHh1N9OlQ0zhXv3oFGo0shyZ5k0tewOAjXDrah6DRyYLDgkNa/Uk9g2dtaE3UoPvaYFu OECVm3xhDVNSzGIX0f6/IjiU7kV7cIPQGJ2q1aN6+6xx4AsC3eL15QS6iRA6ZFUFom/j I3d8Ogd0GiZ1pETIla1JiStzaeLtC0DDBCEcSqP2QcN/XB1cXCJ+lhiYW2ThEjKgAREm 9+8HOTD7EgohbpEpDAUxU/amxomlfxErb0OTe4sN1fNZxtHz7So5iOL9h5VpVZrhNNdZ ZPBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:date:subject:cc:to:from; bh=Y7mI4ksVrJnPScFplLDetqezzLx2MfPmWSK4l6h+ask=; b=ClcQQC01I0CQBRdlo2Z8gfm4iwCTEyFka7PB0NyDNJuX2JX9G1+IEB1EIK1iCuQC8r hdcLmrqmI5YKwQnBfPhLSfJjwoa2nWHgbrFteo1j41knEWGdeFTBX5GdXDtat4Sund4Z wNxikjhiTkujdBxLp3d8HIsxj3qy8MRz2CHKgoFJeP4fOFl00l2eRKDFir1UdiQWMDqx 7zU26O/bxnXoyCWv7mzS0ZEbCjp9Areq7ZniANkI/8IAoL3zsbKZLaYkuoefC2bjS1WI CjdVkFOr/bMRrUKlrJ/859NQlhalXL1qm6Oz+iqYdiGjLJKRR3Fzf3IEpZvqVfg3kuA6 TeZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si5986454edv.287.2019.09.29.23.24.51; Sun, 29 Sep 2019 23:25:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729700AbfI3GYJ (ORCPT + 99 others); Mon, 30 Sep 2019 02:24:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39730 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729668AbfI3GYJ (ORCPT ); Mon, 30 Sep 2019 02:24:09 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8U6M15G062774 for ; Mon, 30 Sep 2019 02:24:06 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vbak5kcmj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Sep 2019 02:24:06 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Sep 2019 07:24:04 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 30 Sep 2019 07:24:00 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8U6Nxng20709844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Sep 2019 06:23:59 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9BCDE42047; Mon, 30 Sep 2019 06:23:59 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 45CE342042; Mon, 30 Sep 2019 06:23:59 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 30 Sep 2019 06:23:59 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 7E5EFA018E; Mon, 30 Sep 2019 16:23:57 +1000 (AEST) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: Andrew Morton , Oscar Salvador , Michal Hocko , David Hildenbrand , Pavel Tatashin , Dan Williams , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 0/1] Add bounds check for Hotplugged memory Date: Mon, 30 Sep 2019 16:23:45 +1000 X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19093006-0028-0000-0000-000003A3DD66 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19093006-0029-0000-0000-0000246604F2 Message-Id: <20190930062347.23620-1-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-30_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909300067 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva This series adds bounds checks for hotplugged memory, ensuring that it is within the physically addressable range (for platforms that define MAX_(POSSIBLE_)PHYSMEM_BITS. This allows for early failure, rather than attempting to access bogus section numbers. Changelog: V6: - Fix printf formats V5: - Factor out calculation into max_allowed var - Declare unchanging vars as const - Use PFN_PHYS macro instead of shifting by PAGE_SHIFT V4: - Relocate call to __add_pages - Add a warning when the addressable check fails V3: - Perform the addressable check before we take the hotplug lock V2: - Don't use MAX_POSSIBLE_PHYSMEM_BITS as it's wider that what may be available Alastair D'Silva (1): memory_hotplug: Add a bounds check to __add_pages mm/memory_hotplug.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) -- 2.21.0