Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Sep 2019 09:21:57 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Chao Yu <yuchao0@huawei.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment
 bitmap of LFS curseg
Message-ID: <20190930072157.GB22914@atrey.karlin.mff.cuni.cz>
References: <20190929135031.382429403@linuxfoundation.org>
 <20190929135040.450358370@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190929135040.450358370@linuxfoundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi!


> +		for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) {
> +			if (!f2fs_test_bit(blkofs, se->cur_valid_map))
> +				continue;
> +out:
> +			f2fs_msg(sbi->sb, KERN_ERR,
> +				"Current segment's next free block offset is "
> +				"inconsistent with bitmap, logtype:%u, "
> +				"segno:%u, type:%u, next_blkoff:%u, blkofs:%u",
> +				i, curseg->segno, curseg->alloc_type,
> +				curseg->next_blkoff, blkofs);
> +			return -EINVAL;
> +		}

So this is detecting filesystem corruption, right? Should it be
-EUCLEAN?

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html