Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap
 of LFS curseg
To:     Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Sasha Levin <sashal@kernel.org>
References: <20190929135031.382429403@linuxfoundation.org>
 <20190929135040.450358370@linuxfoundation.org>
 <20190930072157.GB22914@atrey.karlin.mff.cuni.cz>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <43edc2f2-5b42-0cd7-1573-af77fd9e6678@huawei.com>
Date:   Mon, 30 Sep 2019 15:36:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190930072157.GB22914@atrey.karlin.mff.cuni.cz>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,

On 2019/9/30 15:21, Pavel Machek wrote:
> Hi!
> 
> 
>> +		for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) {
>> +			if (!f2fs_test_bit(blkofs, se->cur_valid_map))
>> +				continue;
>> +out:
>> +			f2fs_msg(sbi->sb, KERN_ERR,
>> +				"Current segment's next free block offset is "
>> +				"inconsistent with bitmap, logtype:%u, "
>> +				"segno:%u, type:%u, next_blkoff:%u, blkofs:%u",
>> +				i, curseg->segno, curseg->alloc_type,
>> +				curseg->next_blkoff, blkofs);
>> +			return -EINVAL;
>> +		}
> 
> So this is detecting filesystem corruption, right? Should it be
> -EUCLEAN?

Was fixed in another commit 10f966bbf521 ("f2fs: use generic
EFSBADCRC/EFSCORRUPTED"). :)

Thanks,

> 
> 									Pavel
>