Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp6626477ybn; Mon, 30 Sep 2019 00:47:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/Yb04aJwGtAsTV2pAhHy3qlffV8aq9puo/H3h7jTbpqMLwNsGUVF0D+FTgVxiLOCbXvdq X-Received: by 2002:a17:907:211c:: with SMTP id qn28mr18110103ejb.244.1569829639800; Mon, 30 Sep 2019 00:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569829639; cv=none; d=google.com; s=arc-20160816; b=C+3Am/YBWbv2xXKMkh4Ys6jmW+ntEnCkqtwi01vgcF4D9DRHSmJpTYHyWSu5N+nB9o sYnfd5Mmq9/BsGUr6RPLQNwu/P5S6puGmzYiXJJ4Ud/EbWOrUDxU3Ctb2MBMWBoVDNWP o9wbqgNhB9r/8M4UwGUkpuhgYor2UNgRP8mjwpEXVroipjxHODy14VlJF60GGsI7uG+/ /liMGp4HLV/SiwCgompUnlRYHtLD0PKDjgW8jcdBHetWg43JKc6+SIbA/tT1gBlkUNou YmE61k9McWsqNRUTXCzU/WpVrrtKVp9Kdh/sjo+YiONkno27gkg22R9/XHzVFO5xY4l2 p3rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=AKsJKdSG5R8dGV+DIPEx5nlyGaSi4dLBqBkbszm5F9M=; b=qTF7QsLSsr7H2lKHzNrevATOfEMb+DSi5BGN+nelnqSlTBaQSex3JCP1h3xwKlz8OE xAn5jNgqB4II5ESu+f1NMkQh9XyaVhGU6H5J7DTzNTj8zIwPVg9SaoukkEC/8YtAi3xq SwWO2DvLcfyo5ae6gyeIVMtoIAc7g4GIiwHrZuJf/Usu3hDN9/VNptomMePDVGW2mJFV R40LUNJxkJLsKwGJcmTp2nBm1Lmhvur4p9fmmNrrOZ1nzjLD0SbA/DyAQVJ7M//MyQHb RlFEpNDg8++jUXl6qxTPhpLGdTHEuAXz2FhJAqKt5qWcmUFLpdcBj6mOrr9fpzjNygRk HIcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fDhmfO1e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si6356953edd.431.2019.09.30.00.46.55; Mon, 30 Sep 2019 00:47:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fDhmfO1e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729748AbfI3HpB (ORCPT + 99 others); Mon, 30 Sep 2019 03:45:01 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:33127 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfI3HpA (ORCPT ); Mon, 30 Sep 2019 03:45:00 -0400 Received: by mail-lj1-f193.google.com with SMTP id a22so8372545ljd.0 for ; Mon, 30 Sep 2019 00:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AKsJKdSG5R8dGV+DIPEx5nlyGaSi4dLBqBkbszm5F9M=; b=fDhmfO1ekIhNvjKsqu2BsmStSF9nq0Zinum0JZkMIVnBK74vRI2OHnevK7Po77juxo wZNaqHXYAw0hfKDmBaM7F4RixYxIKCWaBO0mNC8iziTCWZK+uS4QHO4rXZDXiaEfLygH 6dtTyf6tCdnC6iQInJWYB4tipgjNHLEjgX5SShutOLWDwlxB9t32yJrBytP2ps2TTFZn UUYqdQp9IKvyJ1o301IuR30H6QOSG3r3NYoOvnSRrk5OZep8gRjNYNPGhe6823CjLpoz CHZgYarv+oRpDsXMfjjM7ER0e9znBwxZs421i309nrrMRj3E+iyOBEbnkcJzkC3gxlQu ETQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AKsJKdSG5R8dGV+DIPEx5nlyGaSi4dLBqBkbszm5F9M=; b=CSBy0Ez898UmJHtHaUN8dP09nKgPhg/PTSecsBIM0zqyks/o4XWbN3HxZT0WgsBgfN 4S9Xs7TR7wYBmCCn0awB5HTHIfkOxmz2LsX+AlXTeXrftiFdCh3IFZ4S7132s4ArvEJn VZlw3tMnQGnWd1lstGubGjKjOeLjuH3To9d904VBYEHJoeA39sLjQ3Gegu7LYqqSNyvm Y9CryAM1TSGV4B+n+8B9nySes+Fs0fNV7/LxZHd5f9NX27Bkng4UoEoaiuQUJV+k6/t4 nZ1QvjQmL7ALLa0ZLfKV7DOYCHcaWEYcHjeGpGBPXpozqloZxfvH5In+0KdxUT6Hvvww AGDA== X-Gm-Message-State: APjAAAVXloC3s+WP3IRumM6PDZxMy+FKNamZ/BhU7d3QB6NBgk+sz3Ik tePQRHkX6PIzMgMLUeKjMw20FRl/TJyKrqN8FPrU8Q== X-Received: by 2002:a2e:42c9:: with SMTP id h70mr10772967ljf.88.1569829499004; Mon, 30 Sep 2019 00:44:59 -0700 (PDT) MIME-Version: 1.0 References: <1568878421-12301-1-git-send-email-vincent.guittot@linaro.org> <1568878421-12301-5-git-send-email-vincent.guittot@linaro.org> In-Reply-To: From: Vincent Guittot Date: Mon, 30 Sep 2019 09:44:47 +0200 Message-ID: Subject: Re: [PATCH v3 04/10] sched/fair: rework load_balance To: Rik van Riel Cc: linux-kernel , Ingo Molnar , Peter Zijlstra , Phil Auld , Valentin Schneider , Srikar Dronamraju , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Hillf Danton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Sep 2019 at 03:13, Rik van Riel wrote: > > On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > > > > Also the load balance decisions have been consolidated in the 3 > > functions > > below after removing the few bypasses and hacks of the current code: > > - update_sd_pick_busiest() select the busiest sched_group. > > - find_busiest_group() checks if there is an imbalance between local > > and > > busiest group. > > - calculate_imbalance() decides what have to be moved. > > I really like the direction this series is going. Thanks > > However, I suppose I should run these patches for > a few days with some of our test workloads before > I send out an ack for this patch :) Yes more tests on different platform are welcome > > -- > All Rights Reversed.