Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp6717704ybn; Mon, 30 Sep 2019 02:37:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqyoTmrFlsJo2LkDBycnI6Dpe5xgXOOMNEFCXubo4nQ5BZkGzVwedy7H1P0GPN0mGt1ZIY X-Received: by 2002:a50:b685:: with SMTP id d5mr18511497ede.258.1569836220480; Mon, 30 Sep 2019 02:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569836220; cv=none; d=google.com; s=arc-20160816; b=sKA/pB+dhWvVBzLFKZi0XgTj1A3fs0sIBAN8FFH3fueupdbVvxh4NlMUAESjad56qC u5zo0V+y4JyAIXDUUOuoBz3QkojEWum9LXkwNZI30qHchfd9Ad5SwePUpfiABXUmRW62 rszTGbYPYnN/prx+6uBBDjHPIiBuf30MailME8BBVcMmNBrmVoZ99cp72mgU+38txpLX iBYCtnvQ0ReJjKfhdTw/Vlv0cv3FC/1gTwO//5Wr2vNZ8irWI4BL9xVm8RZ4dvTXR19+ Q9fDn/+IOxPk2cIv6d1admMQAkP0lluDhPNPPSMzjgo18ghKkt86m8RBYR2N4/mll76u M2JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=peexruKHTT6WJbQZTvJ9dOy/fxlnd8Uwh1ObakV73T0=; b=GqYKrPPIYWTf+kNigrr0CmUzOKrM2dfnLLXio3sZw67X1W2Y60LOXagtoxmbWxNCEl 5BoE2RDZ5bVHRyLOaqvsYQeuSPM1NI3To+Nn4NO/5PYVk3w8lGUqE/IZ4McZqyGPd6TF e3bPSdZLxrtEc/pBVILqAN97yHLCHuY9swvJlts2PT9deLMJeltB2ELkXY50WjfpsVLx 8jc7zwdy6h8rjRsAOQDhMRRwbj6GpZbX5aBjqqszXtDQVzd9UwNONQbZTKJDTysV6PK5 5joiFCUhVIUVC6SlnLRlWj6Msp11p6kdduajLA2ex+yjPNZcoplTv0IecQXjkngQ6tZa cLww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qq19si6575401ejb.85.2019.09.30.02.36.36; Mon, 30 Sep 2019 02:37:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730478AbfI3JdR (ORCPT + 99 others); Mon, 30 Sep 2019 05:33:17 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:56849 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730419AbfI3JdR (ORCPT ); Mon, 30 Sep 2019 05:33:17 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iEs3N-0001eD-IW; Mon, 30 Sep 2019 11:33:13 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1iEs3M-0002ou-A5; Mon, 30 Sep 2019 11:33:12 +0200 From: Oleksij Rempel To: Jay Cliburn , Chris Snook Cc: Oleksij Rempel , Pengutronix Kernel Team , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] net: ag71xx: fix mdio subnode support Date: Mon, 30 Sep 2019 11:33:10 +0200 Message-Id: <20190930093310.10762-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver was working with fixed phy without any noticeable issues. This bug was uncovered by introducing dsa ar9331-switch driver. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/atheros/ag71xx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 6703960c7cf5..d1101eea15c2 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -526,7 +526,7 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) struct device *dev = &ag->pdev->dev; struct net_device *ndev = ag->ndev; static struct mii_bus *mii_bus; - struct device_node *np; + struct device_node *np, *mnp; int err; np = dev->of_node; @@ -571,7 +571,9 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) msleep(200); } - err = of_mdiobus_register(mii_bus, np); + mnp = of_get_child_by_name(np, "mdio"); + err = of_mdiobus_register(mii_bus, mnp); + of_node_put(mnp); if (err) goto mdio_err_put_clk; -- 2.23.0