Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   vishnu <vravulap@amd.com>
To:     Mark Brown <broonie@kernel.org>,
        "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@amd.com>
CC:     "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
        Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ASoC: amd: added pmops for pci driver
Thread-Topic: [PATCH 4/5] ASoC: amd: added pmops for pci driver
Thread-Index: AQHVdGQibyt3z1lI7UG+S6l0oFutj6c+RpMAgAaL/wA=
Date:   Mon, 30 Sep 2019 11:30:28 +0000
Message-ID: <87475117-31f9-ac80-58c6-7db384e805f4@amd.com>
References: <1569539290-756-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
 <1569539290-756-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
 <20190926182448.GE2036@sirena.org.uk>
In-Reply-To: <20190926182448.GE2036@sirena.org.uk>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.204.159.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2fe9a260-faf0-48ae-25e2-08d745999803
x-ms-office365-filtering-ht: Tenant
x-ms-traffictypediagnostic: DM6PR12MB3610:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR12MB361050C60A42F5D112C8F7ADE7820@DM6PR12MB3610.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-forefront-prvs: 01762B0D64
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(189003)(199004)(6116002)(31686004)(4326008)(8676002)(305945005)(6436002)(6506007)(102836004)(6512007)(36756003)(66066001)(386003)(31696002)(6246003)(76176011)(26005)(7736002)(14444005)(99286004)(256004)(6486002)(53546011)(186003)(5660300002)(229853002)(71200400001)(2616005)(25786009)(71190400001)(52116002)(4744005)(486006)(54906003)(66946007)(14454004)(66476007)(66446008)(476003)(66556008)(478600001)(110136005)(64756008)(11346002)(3846002)(8936002)(316002)(81156014)(6636002)(446003)(81166006)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB3610;H:DM6PR12MB3868.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: O8E5K04iU3lRbfFLWObxYJ7/whbjkRpMClk7g7zZle3cb0RhzUxHNMCSYsQOtvtiLITmLeM1iyuQ8Ji4C1ibsHQ8+XPzFlAekSGlzIn9/XKBMKmR9iLaUUbjQgr1vre/GblqvP5t7ljKCiWoJuOtR0lGImZwwoc1JBz/jVne4fbIgrtIRC4X7OtKAwvEBHQwi4OgbWqd9l021aIRiyweGT5kgGBNZec6bEkJFw8rjf4MdxjhZILrk870dVAE78T9iyavHxF/13IIMy8um1IrQtbTc0IQU9Ym8RE6P3G8or11dTtsuhYi/amLB/opVqQA1unqjiXDzwLtGE9b9Mv7Zzr7MmahYzKsMMM0AR8Cg5Y/rjrZEPEgqV/TTdjX/WnBAECLQ7YXnsSeN2vTdD3KonW85QILh44LDV5ree+n9aI=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <FCA37D53D0062E4085B2E2CAC31F818D@namprd12.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fe9a260-faf0-48ae-25e2-08d745999803
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2019 11:30:28.1658
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nq46/cnMjrPlZhB85GX2dE7HWJWiMx9fCydTJKXwDgOOqJa2F8vat+mT1M4lEyPVyNZ2ujxinGZADDv0lVnQew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3610
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

Thanks for your suggestions.
Please ignore all the patches.I will address all the inputs shared by=20
you and resend them.

Thanks,
Vishnu

On 26/09/19 11:54 PM, Mark Brown wrote:
> On Fri, Sep 27, 2019 at 04:37:38AM +0530, Ravulapati Vishnu vardhan rao w=
rote:
>=20
>> +static int  snd_acp3x_suspend(struct device *dev)
>> +{
>> +	return 0;
>> +}
>> +
>> +static int  snd_acp3x_resume(struct device *dev)
>> +{
>> +	return 0;
>> +}
>> +
>> +static const struct dev_pm_ops acp3x_pm =3D {
>> +	.runtime_suspend =3D snd_acp3x_suspend,
>> +	.runtime_resume =3D  snd_acp3x_resume,
>> +	.resume	=3D	snd_acp3x_resume,
>> +
>> +};
>=20
> These operations are empty so they should just be removed.
>=20