Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp6839964ybn; Mon, 30 Sep 2019 04:45:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyk9ssI9o3GwOAYjY7O0AHlXiyGjaHtYR6CHWd30iM/1EQNW8cfscZds0Cbaq9fH84d+J27 X-Received: by 2002:a17:906:454c:: with SMTP id s12mr476711ejq.69.1569843932661; Mon, 30 Sep 2019 04:45:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569843932; cv=none; d=google.com; s=arc-20160816; b=J1Lln0TYRj/6g9g1eBpJiZ6uKguCXNa//RzmvF6XR5AnLJYVi7ZVFP4zBLNDICg9fh xzwJGH1sULiAaoxUIDH12Lscaz+Mo1eWirLA8q0fZFrEl7iKlPvmioKfSvK6LnE6Dccz muFq7fPTx6DJNksiDS7+sgeebjS12EfupQf97kBq1A7AaC6ZQvYKBnJ7noLnVcWfNtS4 YpAoWCwetrwQ9BpWhj5GLyFAUCDrbzFQ2gLyG42BPyM9C/dCtHmP6561Z/ZybZd///JH 2eqgQkhO7iUishMgmYZVamH1Xx8ZIjaxyBFlcs/+CPCio8CXTVl23dAea9a//xRql8D9 HrRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rzzp9JtSMY8B/gEGQJjNHTW8qusfxRW7FdjakyT92pE=; b=jXPTLXm4IA7x8O/3/PJHvhOVUH6GTP1hZeg91dQkB/lj3LEfD/Vcas1zS57XDrFh3S cxsGH2JqLy/HOWA44P1HbKj0YAYGjIc9pDBc+9DZdz1zxSTAkwJUhyAOP992Sj8p1l1L I46DYBSlCR7K7mPZYg9cc0zJXYQn4XQKMMOqHxJM9yMO+BImwYuwuarJ9PHnVZZbnmlM wf4hi1F0DrSiGW/C+pJjItP99zQVc9ZdvJcyTQry75RDviHby3U8AqexY/D+7cII1ADk F/MaV8yafu2FCtrHbrw5GU5mxn8yiRhTADFe7Fv80erwOpNFumxeRLrXXgf2NdxA0OI/ /aWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=BcvCOup+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13si6568522edu.4.2019.09.30.04.45.08; Mon, 30 Sep 2019 04:45:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=BcvCOup+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729943AbfI3LiF (ORCPT + 99 others); Mon, 30 Sep 2019 07:38:05 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:33942 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfI3LiF (ORCPT ); Mon, 30 Sep 2019 07:38:05 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8UBc3mf113627; Mon, 30 Sep 2019 06:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569843483; bh=rzzp9JtSMY8B/gEGQJjNHTW8qusfxRW7FdjakyT92pE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=BcvCOup+UgVr+WykHRJsH0wDcPQDSNsDyQ7ASQov6hgFMlzZqUNShq9929E28NEmA yly+ZgqRG00SctEY1TyB3W/aeaN9TYd94PyJnK1W7qltbxHlKx/KcP0Sqo7380JOdH Kqrk8YGTIWXGg0YVd57Am8T7XS7xz7+7/Ar+nju0= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8UBc2fc106969 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Sep 2019 06:38:03 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 30 Sep 2019 06:38:02 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 30 Sep 2019 06:38:02 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8UBc20i105077; Mon, 30 Sep 2019 06:38:02 -0500 Date: Mon, 30 Sep 2019 06:36:29 -0500 From: Nishanth Menon To: Axel Lin CC: Mark Brown , Liam Girdwood , Subject: Re: [PATCH] regulator: ti-abb: Fix timeout in ti_abb_wait_txdone/ti_abb_clear_all_txdone Message-ID: <20190930113607.5l443q7qyg6eovnf@kahuna> References: <20190929095848.21960-1-axel.lin@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190929095848.21960-1-axel.lin@ingics.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17:58-20190929, Axel Lin wrote: > ti_abb_wait_txdone() may return -ETIMEDOUT when ti_abb_check_txdone() > returns true in the latest iteration of the while loop because the timeout > value is abb->settling_time + 1. Similarly, ti_abb_clear_all_txdone() may > return -ETIMEDOUT when ti_abb_check_txdone() returns false in the latest > iteration of the while loop. Fix it. > > Signed-off-by: Axel Lin Acked-by: Nishanth Menon Mark, if you could pick it up, will be great. -- Regards, Nishanth Menon