DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=KHgwbWG58CvvDJohKqdczt6/SA8I4WliDZdJt4e8/GcyijRrjFctdv/rxzNzasS8eEBoGeCwn2ZnnPzszFv7El9Y1Y8rmEqIovACdv5aKbqdq5EcIkhm0hhdo0B/n3hT7LxWSy9nHhN8QB7ELZ2s3z+RQLYz5Xi4CLX5jB1zYfQ=
Message-ID: <6ec4247d0601030419w377fd396x@mail.gmail.com>
Date: Tue, 3 Jan 2006 22:49:33 +1030
From: Graham Gower <graham.gower@gmail.com>
To: Roger While <simrw@sim-basis.de>
Subject: Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
In-Reply-To: <6.1.1.1.2.20060103105620.02c523e0@192.168.6.12>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <6.1.1.1.2.20060103105620.02c523e0@192.168.6.12>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 966
Lines: 23

012345678901234567890123456789012345678901234567890123456789

On 03/01/06, Roger While <simrw@sim-basis.de> wrote:
> What makes you think this is in IRQ context ?
>

Er... yeah. I must have been off my nut when I wrote that comment.
A more apt comment should perhaps have been "dev_kfree_skb shouldn't be
used with interrupts disabled". Forgive my noobness, I'm a kernel patch virgin.

My logs were starting to fill with messages exatcly like that mentioned here:
http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840

In any event, the patch at the end of that link was never applied (it doesn't
fix the other call to dev_kfree_skb). After applying my patch, I've not had any
more messages in the logs.

Graham
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/