Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Sep 2019 09:22:55 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment
 bitmap of LFS curseg
Message-ID: <20190930132255.GT8171@sasha-vm>
References: <20190929135031.382429403@linuxfoundation.org>
 <20190929135040.450358370@linuxfoundation.org>
 <20190930072157.GB22914@atrey.karlin.mff.cuni.cz>
 <43edc2f2-5b42-0cd7-1573-af77fd9e6678@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <43edc2f2-5b42-0cd7-1573-af77fd9e6678@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 30, 2019 at 03:36:16PM +0800, Chao Yu wrote:
>Hello,
>
>On 2019/9/30 15:21, Pavel Machek wrote:
>> Hi!
>>
>>
>>> +		for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) {
>>> +			if (!f2fs_test_bit(blkofs, se->cur_valid_map))
>>> +				continue;
>>> +out:
>>> +			f2fs_msg(sbi->sb, KERN_ERR,
>>> +				"Current segment's next free block offset is "
>>> +				"inconsistent with bitmap, logtype:%u, "
>>> +				"segno:%u, type:%u, next_blkoff:%u, blkofs:%u",
>>> +				i, curseg->segno, curseg->alloc_type,
>>> +				curseg->next_blkoff, blkofs);
>>> +			return -EINVAL;
>>> +		}
>>
>> So this is detecting filesystem corruption, right? Should it be
>> -EUCLEAN?
>
>Was fixed in another commit 10f966bbf521 ("f2fs: use generic
>EFSBADCRC/EFSCORRUPTED"). :)

I've queued up a backport of this for 5.2, 4.19, and 4.14, thanks!.

--
Thanks,
Sasha