Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp6973621ybn; Mon, 30 Sep 2019 06:47:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMPb5cpiWICj/UCHmmmSUwLpbTuSPmEC4IOC2GOP62jXTcupC57mJviLPDn6tUONdjZOYc X-Received: by 2002:a17:906:c7c6:: with SMTP id dc6mr19812149ejb.123.1569851257022; Mon, 30 Sep 2019 06:47:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569851257; cv=none; d=google.com; s=arc-20160816; b=GGBl3FYcdfHsTeaziGYaKg81gQVeAbFyWXEUdVacZzcdT53AHc4/n0UIKhK54mNOpm Up+V3FE0CHmP5L7RbuCznNOdX8dxy7cT1beWp335ptnxIFyOaACZQuZUlgkHk03SDzHr /BeH84RFOImIJhcUWzO5RtKfjUOtPXV86QfpQVOJyHcyU/yxtcdBmzOtqK3NBKpOBNRf 34Jqq7tZBstAZdAoal6/DTEv4cpYPsiHs0QEZ+14360xEolTOafGZ/IJlTd9HhOyQ62k pjI/no944LY12DU215HM2DisF47kW7gYnKOKOs+RF1g2BgB8TacWYTIHjHOpmoY6m7rY dsbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MwogyXtzP30qqSg8Krvf2WUMszyfL/MxA1RY0E6lYWM=; b=yv7MS5cOjascg1mGLu6x+LRgCZ6EoyMQ1TGiA2txqPKHhVw/QCRk6nTmkr9lFi5Qwk 3ataO9xXLR0/3paJIKG3T4FB2rCfO0OsSWVpCp82gkV2xaYrnLftl0MI2Jcy+wh4Bci/ nOLZYOrwG5gAZ/7/M4DBHGeVz8rPrNDkEWRYjyV73coWcUTzLdB8w805ubjWZHqSnMp3 dDzZ1cHR0aWQc8U2uP4B2oDjyivbVEKx3NoQxGr3KYyzo+CIXgbFHdzJFH27EXJoG15d ooHaHJIZa5PbIg5iu9fmSTKnJUsbgZWoIANT+uv+J9G7HV/iGKVxaGxP+VAtudAFmzHF uxcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=SIA99rrS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g38si7203286edg.127.2019.09.30.06.47.11; Mon, 30 Sep 2019 06:47:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=SIA99rrS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731263AbfI3Nqt (ORCPT + 99 others); Mon, 30 Sep 2019 09:46:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54488 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731062AbfI3Nqt (ORCPT ); Mon, 30 Sep 2019 09:46:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MwogyXtzP30qqSg8Krvf2WUMszyfL/MxA1RY0E6lYWM=; b=SIA99rrSZ7/5jFcId9jm+tB4Ta UH0JlYISGTAI1X2cSwOelq1gC/zGtisKMx7hgPzSwnBzVYvMpzUBMr5xNBJgNXXFqLR24WFobTfJK g1ZwDhHexUChlsXzFesb/yOdT/6EfuuOjfl5/TQZbrfxKCQfWKBU6R+pziqgbAYtHk8M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iEw0j-0003x0-G5; Mon, 30 Sep 2019 15:46:45 +0200 Date: Mon, 30 Sep 2019 15:46:45 +0200 From: Andrew Lunn To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: "David S. Miller" , netdev@vger.kernel.org, Vivien Didelot , linux-kernel@vger.kernel.org, Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH net] net: dsa: qca8k: Use up to 7 ports for all operations Message-ID: <20190930134645.GD14745@lunn.ch> References: <1569488357-31415-1-git-send-email-michal.vokac@ysoft.com> <07dda3c6-696c-928f-b007-8cda9744b624@ysoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <07dda3c6-696c-928f-b007-8cda9744b624@ysoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 30, 2019 at 03:34:31PM +0200, Michal Vokáč wrote: > On 26. 09. 19 10:59, Michal Vokáč wrote: > > The QCA8K family supports up to 7 ports. So use the existing > > QCA8K_NUM_PORTS define to allocate the switch structure and limit all > > operations with the switch ports. > > > > This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and > > disable all ports") disabled all unused ports. Since the unused ports 7-11 > > are outside of the correct register range on this switch some registers > > were rewritten with invalid content. > > > > Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") > > Fixes: a0c02161ecfc ("net: dsa: variable number of ports") > > Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports") > > Signed-off-by: Michal Vokáč > > More recent patches on the list are getting attention. > Is this one falling through the cracks? Probably not, it is missing a review-by, from somebody David trusts. Reviewed-by: Andrew Lunn Andrew