Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp7007842ybn; Mon, 30 Sep 2019 07:17:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwyOCcDgt2JvHm9jU6qyhJjnn7Fwb2CYGj1eS3r/gFoyU4dZ3Cj6f5FW0NK3pFZJPD/C8c9 X-Received: by 2002:a17:906:d8a9:: with SMTP id qc9mr19431983ejb.199.1569853072054; Mon, 30 Sep 2019 07:17:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569853072; cv=none; d=google.com; s=arc-20160816; b=y7OpvxW1R6Zatv4+FXjCfbxRvmztGu15BaI8KF1UhL1IUh8KbxjI6rfGLSnikASwjb momGcGbB2d62nyVk7uSgoX51u8IKDvopagVGxXpE6g+x51ZJQnw0cfghqbhJUowmPSnh esgTUd8wLx0wCjMlSr03qJc/a9Q40KeT4N13yssqKf/G24cAMMlfFfL/tnV6CUDF/Ozj UR2P9aG/zTnxXT3Lwz76I2fTl0dqLNKwo0IOoHe7b21GekqkeKxBmzNIiIfftInq7YOn Q9+X7UTtoPLqBMDxSRwIO3Rbk0GRwRFtCS1ln+XgwFZeVc2qP72Ot4AIJ08kk0Y1/Q4H bbsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=qSyzuXDiOCBGYUe5x3wq3t+cEuvzBt8YWh4PsSfAxng=; b=r7POcfocLvDNybLgr/krJXEFcM+pMXKnv733vbaPiK7plV6hmlN3TOlYNemElBemz0 Asr+1OeH6HH+mDkJKklCHj4qBQtdyg29+tFLV4goajCqqfEijQrRfJmZuF6XsCAYJLoH xNbxoF5H8Wii6cFo4H04fYAGJv4Q4G5OFkxpQjN1UsFwi+Qxaro98J3QtevYVKIuKG5e RTRFgJv8PrKjwjCVW3XumnSyMi1T3pK8Xv7uzIg4rtm/VYgBpVsH8s92uoa1C1AVYlHH +RhBNBjlJi6cpzuItBBxNXZlLV3mn0j1WoM94Nfc2+RmuwvSroaBkw8mrq+GxRJrlpCw vsZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=UN3DqBAK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a24si7032733ejg.127.2019.09.30.07.17.27; Mon, 30 Sep 2019 07:17:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=UN3DqBAK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731113AbfI3OQ6 (ORCPT + 99 others); Mon, 30 Sep 2019 10:16:58 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:42165 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730923AbfI3OQ6 (ORCPT ); Mon, 30 Sep 2019 10:16:58 -0400 Received: by mail-io1-f68.google.com with SMTP id n197so38652201iod.9 for ; Mon, 30 Sep 2019 07:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qSyzuXDiOCBGYUe5x3wq3t+cEuvzBt8YWh4PsSfAxng=; b=UN3DqBAKeUwm8D0QEQjS3xJkE3+G7UwQhw6O0nfYZs1PZxchfelnwuw6XbPAxU+6iT z7SVP3YgvJDIJkPDy8Bfe1iwyqHZfIHIy7DYtqo1N8vSDthWvJQNB9ATkSpZlZ3XCuki qXAC8XV3pv/MJIMPSXlVWaEDCm27ZkGzg0pXY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qSyzuXDiOCBGYUe5x3wq3t+cEuvzBt8YWh4PsSfAxng=; b=sIg94TG34c7qDdXBhmHACNuPxJJMpHt0D+zYNGcDRxaToxr9v9vcVWLogfCcPsOcu0 yfvZbV6zB5lIoqG0HIknJScez81kj86rNIG9EL+T5jaokgXbfdPDIq5/51Ig7HjP4ijw JZCn4EipAOnvfbalqDKpon3sysIpf3MyIz9oW4SpL2zvSnDxG730QKC7xr0Cs9HLZ1Tz sbeDjguLtn0k9F0QyBO0b7eYX7eRE+sJXFI93SA6LsTNhr+4Xo1xoQpOAOQvrJmhQCFe ldzkpLqYYw6aVtcn8M2OLAPo565YNC552jEcdNULy0Gxxs+yruGG+vyRb24k81pW6VQi xsJw== X-Gm-Message-State: APjAAAUz7YPhRZBYnhKBalbqsJAipxRup0QVGLZfsk6hj2G8GUVtOorA kcE8Ja8SxOKlyORxalU16XqbPcHoXJs= X-Received: by 2002:a92:6c10:: with SMTP id h16mr6350326ilc.299.1569853017550; Mon, 30 Sep 2019 07:16:57 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id r2sm5475403ila.52.2019.09.30.07.16.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 07:16:56 -0700 (PDT) Subject: Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree To: Daniel Borkmann Cc: ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20190927011344.4695-1-skhan@linuxfoundation.org> <20190930085815.GA7249@pc-66.home> From: Shuah Khan Message-ID: Date: Mon, 30 Sep 2019 08:16:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930085815.GA7249@pc-66.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/19 2:58 AM, Daniel Borkmann wrote: > On Thu, Sep 26, 2019 at 07:13:44PM -0600, Shuah Khan wrote: >> make TARGETS=bpf kselftest fails with: >> >> Makefile:127: tools/build/Makefile.include: No such file or directory >> >> When the bpf tool make is invoked from tools Makefile, srctree is >> cleared and the current logic check for srctree equals to empty >> string to determine srctree location from CURDIR. >> >> When the build in invoked from selftests/bpf Makefile, the srctree >> is set to "." and the same logic used for srctree equals to empty is >> needed to determine srctree. >> >> Check building_out_of_srctree undefined as the condition for both >> cases to fix "make TARGETS=bpf kselftest" build failure. >> >> Signed-off-by: Shuah Khan > > Applied, thanks! > Hi Daniel! Is the tree the patch went into included in the linux-next? thanks, -- Shuah