Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp7425214ybn; Mon, 30 Sep 2019 13:44:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXvEoW6WZAdd9EYbOIRAFAbe3PugYeBResbhM8/ZXJVuNT63HQ3XCJ8ZdlGKEcBs6CFjCN X-Received: by 2002:a17:906:c738:: with SMTP id fj24mr21341155ejb.255.1569876278805; Mon, 30 Sep 2019 13:44:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569876278; cv=none; d=google.com; s=arc-20160816; b=BA+EZ1UlvVxvebMxlsDYTxjvTE84fVxrrGFlDlAoIUICxklexs7KsFo6QfLMP1ooON 0xv0atnSoHQtyn8B8xpoBma2laWVVcbpMTHuXvtRXXDNUonw9QI2vNr0Z5XQ624TXTRW xeAnuL8Yr2gmENIjenbL94uP6A/5owpz2hb4y5f8kKWKvIBz9HiQYbWoTNmX/BVCutv1 3CTxj5bTWq6bfl/MRZ+W2hW8Y6irL4TbuUyT9qEPm/Ou9gW+nqqIEAq5N5mKssrf/s1L CctW0cJ6GbZfvil7YH+2lQBL8L6R6PwdTbhG7TCSNPNlXY0CXkdci/sWo9yYYL2ZQ1s4 SJzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ab8erVBJ0HDiPy/U9zIkKgiV7QCkkURjA/RwfGAn1gE=; b=aGe2Hfrxxfy7YXLFOrpQXMfakHC7MjsFRFEwwWacE+bn5/0G3kOg/KJsiCncWt8zWn Ox4/1oxc49aTkIXutdkDK/5eF+qMpaxidqiHOdi5ZRJU7fToRBKPNwsyMkitdIUH+RQa 9t1lxbZmyfOJECsHuGK0ioSuvxHqr/Xt14yAfq/2mOkJckOP4Ey1gVwjDZT59ZMf14Tm IxM681YTGahgefIr/WMVdeSIHOYonL/4MAowlLkHnh03hNfOqy/HI0q3RaU8U9idV0Pv dCyGVKYR8g6//eD9znaA3Ob2LHgO3+p2gPAaL1HR2kpntdqSloLO0B2guRFf3CwTIh6W u2pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oy5si8225310ejb.170.2019.09.30.13.44.13; Mon, 30 Sep 2019 13:44:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732411AbfI3UkF (ORCPT + 99 others); Mon, 30 Sep 2019 16:40:05 -0400 Received: from www62.your-server.de ([213.133.104.62]:60488 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730607AbfI3UkE (ORCPT ); Mon, 30 Sep 2019 16:40:04 -0400 Received: from 15.248.197.178.dynamic.dsl-lte-bonding.zhbmb00p-msn.res.cust.swisscom.ch ([178.197.248.15] helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iF0KT-0000xK-7e; Mon, 30 Sep 2019 20:23:25 +0200 Date: Mon, 30 Sep 2019 20:23:24 +0200 From: Daniel Borkmann To: Shuah Khan Cc: ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree Message-ID: <20190930182324.GA20613@pc-63.home> References: <20190927011344.4695-1-skhan@linuxfoundation.org> <20190930085815.GA7249@pc-66.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25588/Mon Sep 30 10:25:56 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 30, 2019 at 08:16:55AM -0600, Shuah Khan wrote: > On 9/30/19 2:58 AM, Daniel Borkmann wrote: > > On Thu, Sep 26, 2019 at 07:13:44PM -0600, Shuah Khan wrote: > > > make TARGETS=bpf kselftest fails with: > > > > > > Makefile:127: tools/build/Makefile.include: No such file or directory > > > > > > When the bpf tool make is invoked from tools Makefile, srctree is > > > cleared and the current logic check for srctree equals to empty > > > string to determine srctree location from CURDIR. > > > > > > When the build in invoked from selftests/bpf Makefile, the srctree > > > is set to "." and the same logic used for srctree equals to empty is > > > needed to determine srctree. > > > > > > Check building_out_of_srctree undefined as the condition for both > > > cases to fix "make TARGETS=bpf kselftest" build failure. > > > > > > Signed-off-by: Shuah Khan > > > > Applied, thanks! > > Hi Daniel! > > Is the tree the patch went into included in the linux-next? Yes, both bpf and bpf-next are included in linux-next. Thanks, Daniel