Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Sep 2019 11:06:51 -0700 (PDT)
Message-Id: <20190930.110651.1802452095339417928.davem@davemloft.net>
To:     michal.vokac@ysoft.com
Cc:     andrew@lunn.ch, netdev@vger.kernel.org, vivien.didelot@gmail.com,
        linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
        hkallweit1@gmail.com
Subject: Re: [PATCH net] net: dsa: qca8k: Use up to 7 ports for all
 operations
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1569488357-31415-1-git-send-email-michal.vokac@ysoft.com>
References: <1569488357-31415-1-git-send-email-michal.vokac@ysoft.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-2
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Michal Vok?? <michal.vokac@ysoft.com>
Date: Thu, 26 Sep 2019 10:59:17 +0200

> The QCA8K family supports up to 7 ports. So use the existing
> QCA8K_NUM_PORTS define to allocate the switch structure and limit all
> operations with the switch ports.
> 
> This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and
> disable all ports") disabled all unused ports. Since the unused ports 7-11
> are outside of the correct register range on this switch some registers
> were rewritten with invalid content.
> 
> Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
> Fixes: a0c02161ecfc ("net: dsa: variable number of ports")
> Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports")
> Signed-off-by: Michal Vok?? <michal.vokac@ysoft.com>

Applied.