Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp7494101ybn; Mon, 30 Sep 2019 14:59:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwde0gzYSKDq54MuMK8dMTrEK8foaMwYsK16otq9npyf4WPf3Lsba3XWcwPRwsIlq/q1d7e X-Received: by 2002:a50:9b58:: with SMTP id a24mr22322852edj.29.1569880753999; Mon, 30 Sep 2019 14:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569880753; cv=none; d=google.com; s=arc-20160816; b=qOpIXFpMpo9n6Y1KQGwbAwwj7Trq4qBLmHQxj3OEQvGyeT1x/o4b2jhmaedj4Bd88a 5pxqvW8NnMLSX3L9QHGf4ycFAZqd7sLzqu88TTsPxLWUrs63GSvpcMzJ5YZAuVVTrKj+ xP3lkaI2rjJh38jhI1b1RLSYWRi1G5vq4/ixFrkIMu8R2YkBgXsip/4XCF8Blojcozfp Cbubq7s5pnCPjnd5i+p3HurBERo8UMR5oKOk5hzJwyIP2yiEN64V0F9QDKsx9H+a4JO7 iI7WuEu2buczS1s/muEsOkWdpxL/uD9thKa2H7iVZjktyWW/TqaVBCKiZOP56v5lt2nO RcwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=4G8UhfmOAU+vf176VW3ixtgHtt4omHWSmMUKQqJYu4I=; b=lnwgV/+5Ky++GXCKl/4UYCQd3ApUCTA67qRfi7UUGKe1H0R3uZW81JzHOCwjbs2/r8 4f2ZhLAwuCaXjqPGzhxip6Ugd/zjRBfAtRasMhxlC2e6Xh+hQoVkHktlZGsOSu/QsFVf U/F82xrxoBjT/QQiI9W9SvBmp2GXKfAU8XKKoUqIMp3EBeeM9q/uhVU264BAoVTbprhE ruEK+2yIrxbJ+4E3vSdwwwhyYQiGT696y3VZmZPZ0AcOBB/qBBBWVcEB+HS3iHh1so4C IoVD1odn6AP8vW2XdQCe0uIW2DAmiRQB/2WfLVcNRMfhNzIQuYKNCqe11ojKsGYH6ptG W21A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zxeBRvzt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si8550578edb.433.2019.09.30.14.58.49; Mon, 30 Sep 2019 14:59:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zxeBRvzt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731840AbfI3V5E (ORCPT + 99 others); Mon, 30 Sep 2019 17:57:04 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:40408 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbfI3V5E (ORCPT ); Mon, 30 Sep 2019 17:57:04 -0400 Received: by mail-lj1-f196.google.com with SMTP id 7so11113884ljw.7 for ; Mon, 30 Sep 2019 14:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4G8UhfmOAU+vf176VW3ixtgHtt4omHWSmMUKQqJYu4I=; b=zxeBRvzt144Q4MDycJBV/iY/2eVJfo8OGtkSJ0SJijBO2SEblZzrVzwlMUbAM+75SS LNt8hYAXph/R13Qlfc4X4Ugg10gDi9uZoyrf3aIEGtHaARdlCMS8W6Hv/Gyg1aA7NhRg +5YcShk/mkdFeO4SABR6+AehSLtFVMI9hV0IZvm+xNaDRU5ri2jxn8wN8+R2531bip9n HWBEiqrzP+T1djmmDaowqv+2jDvWaaqtPXvH9ttR19WAiFNmZfzReUc6pUSYmzdCWlCo SGlbCAYv2DyxRTmvQ2x85hx7Fhc++TSYqMt/xumnFrYkYOJyZ42kIwDm0UDHbqZFiWeX mCfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4G8UhfmOAU+vf176VW3ixtgHtt4omHWSmMUKQqJYu4I=; b=q9W4Cn/p2hyspDYbPt6piTkfpw0yUSL+nr8OaTl1iMy5kSx4atYapcCRXbsl5EDdiJ bEFXrZXMWPSsuMPtLznXTXB3sGhaFqn3adK2Jz8MHji7adFk0HS5VR5xEXWjdTuQs3Io HT93Efti6rOTGLX+WNcaSGqLT0mFAtqQaqveSS4p5tTJDWl8sEZzOPckEUAyRl9J1kSW O/5O5I4S64qVgDgv3RWBrQqt0fFulHgVeK++3fCwdwbDNehcPbkCfxK36FsPeviYS6U0 pbhVAK++r0/GJsUy7KlJTUApFxJdCtBs2boDnT5tKRRJ/HYSO98i8lgab8gFVnjVbDAX 4j0A== X-Gm-Message-State: APjAAAVKTbjTU5W1yaqzezCaz3a7mqV1N8XOn2EMPOBC/rPLpUPbLaDS UjiH/jvdoFxKDPmIAtAqgcwn+23q/w5UrQgPkdxghQ== X-Received: by 2002:a2e:b4c4:: with SMTP id r4mr13939072ljm.69.1569880621961; Mon, 30 Sep 2019 14:57:01 -0700 (PDT) MIME-Version: 1.0 References: <20190929070047.2515-1-wenyang@linux.alibaba.com> In-Reply-To: <20190929070047.2515-1-wenyang@linux.alibaba.com> From: Linus Walleij Date: Mon, 30 Sep 2019 23:56:50 +0200 Message-ID: Subject: Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name To: Wen Yang Cc: xlpang@linux.alibaba.com, zhiche.yy@alibaba-inc.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 29, 2019 at 9:01 AM Wen Yang wrote: It's nice to see some Alibaba kernel contributions! > of_node_put needs to be called when the device node which is got > from of_get_child_by_name finished using. > irq_domain_add_linear() also calls of_node_get() to increase refcount, > so irq_domain will not be affected when it is released. > > fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") > Signed-off-by: Wen Yang > Cc: Linus Walleij > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Florian Fainelli > Cc: "David S. Miller" > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Linus Walleij Yours, Linus Walleij