Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp7646201ybn; Mon, 30 Sep 2019 17:50:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0PVIL3ikBKG12wckXaokD3WZn1dZgJSRNgaa9j49w6WwC6uf1/GFpa4PwAluS0lGp0J3b X-Received: by 2002:a17:906:4990:: with SMTP id p16mr22292370eju.9.1569891045224; Mon, 30 Sep 2019 17:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569891045; cv=none; d=google.com; s=arc-20160816; b=FBOnimFRKlGMWHYihuF/gKYdrd0yMoGyUWp43O8SPBfam3quoYDs+zSmfT/LYh8XFy LfZ/1AauqBBBQ6TcoCm1+GK7s8Yay3CLO4ccUgNqLd0mDuZt2ZnaLCgKy+sHbOnVB3qM OOmsnzvfmDkOZLQR3MZhDoV76CN1hcAAezCYXaLLAA7/wPcp3JJ0Febu/oywDPNNLMFc xmS3+7a2ifd1oRRJSWKbbWuYcrTtBbropkcjMp1bPT26pGz6x+gCa3FGLYxRvvTGpNw5 ECN/VppBGW4quM94moPQs06FjL6UBPWSaiD2EVoHI+jnIbb5TxD1FbVIVRb645Oh2kXT 0CbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:date:subject:cc:to:from; bh=FUlVRBcwhYawavftm6BI2h+bghUqCI2Szn5LrfKsKSs=; b=JkuMeJaz0ln2CzQkb/vCDf3kukNhQHnuelwI5D11TuNw2DqDcKEvVE8aw37EECM6gk JDvKiEn4gk9IaMT2FblewbdWHs90Wlk8f9PQ87mMKANwtdZ1MkN2WnZwydO6JV2CzbTc sheJISzxxrR9tpFJwOdCPTCoj6kE32nNadC5FeTuQiwE4/F/aVr76O9W0viK4ZgDqHic ImknlpGp5p6BheWwwO7SVRWmxQOTFKMaEOtNPiryQK//+1gUeLWH52gOd0XIfypqV++D 6o7b4neugwGm6tT9e29NRDlDVGuPItRH9BedadoK2+HKPFuPgAYaOHJw9pCf4ahU5mRF cGTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4si9447853edk.331.2019.09.30.17.50.20; Mon, 30 Sep 2019 17:50:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbfJAAqh (ORCPT + 99 others); Mon, 30 Sep 2019 20:46:37 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:30992 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726858AbfJAAqh (ORCPT ); Mon, 30 Sep 2019 20:46:37 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x910gbHr083494 for ; Mon, 30 Sep 2019 20:46:35 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vbrv8wwdb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Sep 2019 20:46:35 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Oct 2019 01:46:33 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 1 Oct 2019 01:46:30 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x910k1Jv37224860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Oct 2019 00:46:01 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1CA342041; Tue, 1 Oct 2019 00:46:29 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9DAE74203F; Tue, 1 Oct 2019 00:46:29 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 1 Oct 2019 00:46:29 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id E989EA00F8; Tue, 1 Oct 2019 10:46:25 +1000 (AEST) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: Andrew Morton , Oscar Salvador , Michal Hocko , David Hildenbrand , Pavel Tatashin , Dan Williams , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 0/1] Add bounds check for Hotplugged memory Date: Tue, 1 Oct 2019 10:46:14 +1000 X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19100100-0020-0000-0000-00000373345C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19100100-0021-0000-0000-000021C91151 Message-Id: <20191001004617.7536-1-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-30_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010006 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva This series adds bounds checks for hotplugged memory, ensuring that it is within the physically addressable range (for platforms that define MAX_(POSSIBLE_)PHYSMEM_BITS. This allows for early failure, rather than attempting to access bogus section numbers. Changelog: V7: - Cast PFN_PHYS as u64 since it's type is platform dependant V6: - Fix printf formats V5: - Factor out calculation into max_allowed var - Declare unchanging vars as const - Use PFN_PHYS macro instead of shifting by PAGE_SHIFT V4: - Relocate call to __add_pages - Add a warning when the addressable check fails V3: - Perform the addressable check before we take the hotplug lock V2: - Don't use MAX_POSSIBLE_PHYSMEM_BITS as it's wider that what may be available Alastair D'Silva (1): memory_hotplug: Add a bounds check to __add_pages mm/memory_hotplug.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) -- 2.21.0