Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp7729150ybn; Mon, 30 Sep 2019 19:33:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0owYILUOyl/lyBdlyZNhw2VjMulp3GNpDwptokcoc4wydpOzvkqbk6tQuIugkUHei6A5j X-Received: by 2002:a50:f616:: with SMTP id c22mr22684335edn.235.1569897221180; Mon, 30 Sep 2019 19:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569897221; cv=none; d=google.com; s=arc-20160816; b=lwn4RNhFsgGSipsVbW+MA/c480EgVC19UJG/oy+uM6LRjRQ9yNQueHTmPOiMMt1BlS T/tvQZMUunXOYbBwWBx1rg+z7Ya7+E9bBuSOF2u0eYc67BQTcbdqYsMepdIowkytq+dy +PGhGrjH2bC2Ki8BXBhnWjZodFyBr24if4Y2El9eWVmSNFTXl8UtRj/wdM4R91OpBkXE Jwid+Cuhn43HU6d6/RLZvzZL1e0wD8Q1ysvE+eQXdKfi0IaPxGe9ui72ymRoxBYNQZJn SFOxQ4wr/qygbvgJ99vkKTaOkg7Q9wAzvsZbTX4OmwAaleBlndrJ9ioPo6SqSDD3bDiA 1e/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kGoDr+xNeitPWFrzLBDC2JPacMu/BTtcY/Wk5L7KdEc=; b=nhaPegLegMheYPTDwpfa/jl7fhcEQKJZCQ+adLgbbERD0xI+ZddkGL1axBLm7r+7qn dFhLfI866Ep+NTXQfK0iy1IBJVPccZBC/mJP8rQbM8qBTiqkLmdSjvqjjPIQ2FHf5CdT 4xTpY9BY2EyZayaf6tq4bY+FAfJM/Sg6USe7SDBDuT+YIVhTs1dw3rBIFhpTRwMSRQZG Xhxdi99rer7l+qT6BkzMuxAR6tsYq5/qtv/pB4ih101npYuufvcrOTKkuw5uiWo7DGm4 HoUXN+jD+RDCmswlbw7lvUwqquom6DSpskp8XAnpo+4jAyELLBh/484iZynsmPMNvByU J3Jw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f29si8587400ejj.110.2019.09.30.19.33.16; Mon, 30 Sep 2019 19:33:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731077AbfJACct (ORCPT + 99 others); Mon, 30 Sep 2019 22:32:49 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43991 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726789AbfJACcs (ORCPT ); Mon, 30 Sep 2019 22:32:48 -0400 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iF7xt-0005P8-CK; Tue, 01 Oct 2019 02:32:37 +0000 Date: Tue, 1 Oct 2019 04:32:36 +0200 From: Christian Brauner To: Aleksa Sarai Cc: Ingo Molnar , Peter Zijlstra , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kees Cook , Rasmus Villemoes , Al Viro , Linus Torvalds , libc-alpha@sourceware.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/4] clone3: switch to copy_struct_from_user() Message-ID: <20191001023235.kbk3fiskulervlxz@wittgenstein> References: <20191001011055.19283-1-cyphar@cyphar.com> <20191001011055.19283-3-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191001011055.19283-3-cyphar@cyphar.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 11:10:53AM +1000, Aleksa Sarai wrote: > The change is very straightforward, and helps unify the syscall > interface for struct-from-userspace syscalls. Additionally, explicitly > define CLONE_ARGS_SIZE_VER0 to match the other users of the > struct-extension pattern. > > Reviewed-by: Kees Cook > Signed-off-by: Aleksa Sarai Reviewed-by: Christian Brauner