Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] PCI: Add Loongson vendor ID and device IDs
To:     Andrew Murray <andrew.murray@arm.com>
References: <279cbe32-a44b-3190-aaf7-a277a1220720@loongson.cn>
 <20190930140217.GB38576@e119886-lin.cambridge.arm.com>
Cc:     bhelgaas@google.com, zenglu@loongson.cn, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <d3cde609-7918-6b1c-940d-29ecaf7e5cbb@loongson.cn>
Date:   Tue, 1 Oct 2019 10:53:44 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20190930140217.GB38576@e119886-lin.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/30/2019 10:02 PM, Andrew Murray wrote:
> On Mon, Sep 30, 2019 at 12:55:20PM +0800, Tiezhu Yang wrote:
>> Add the Loongson vendor ID and device IDs to pci_ids.h
>> to be used in the future.
>>
>> The Loongson IDs can be found at the following link:
>> https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids
>>
>> Co-developed-by: Lu Zeng <zenglu@loongson.cn>
>> Signed-off-by: Lu Zeng <zenglu@loongson.cn>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   include/linux/pci_ids.h | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 21a5724..119639d 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -3111,4 +3111,23 @@
>>
>>   #define PCI_VENDOR_ID_NCUBE            0x10ff
>>
>> +#define PCI_VENDOR_ID_LOONGSON                 0x0014
>> +#define PCI_DEVICE_ID_LOONGSON_HT              0x7a00
>> +#define PCI_DEVICE_ID_LOONGSON_APB             0x7a02
>> +#define PCI_DEVICE_ID_LOONGSON_GMAC            0x7a03
>> +#define PCI_DEVICE_ID_LOONGSON_OTG             0x7a04
>> +#define PCI_DEVICE_ID_LOONGSON_GPU_2K1000      0x7a05
>> +#define PCI_DEVICE_ID_LOONGSON_DC              0x7a06
>> +#define PCI_DEVICE_ID_LOONGSON_HDA             0x7a07
>> +#define PCI_DEVICE_ID_LOONGSON_SATA            0x7a08
>> +#define PCI_DEVICE_ID_LOONGSON_PCIE_X1         0x7a09
>> +#define PCI_DEVICE_ID_LOONGSON_SPI             0x7a0b
>> +#define PCI_DEVICE_ID_LOONGSON_LPC             0x7a0c
>> +#define PCI_DEVICE_ID_LOONGSON_DMA             0x7a0f
>> +#define PCI_DEVICE_ID_LOONGSON_EHCI            0x7a14
>> +#define PCI_DEVICE_ID_LOONGSON_GPU_7A1000      0x7a15
>> +#define PCI_DEVICE_ID_LOONGSON_PCIE_X4         0x7a19
>> +#define PCI_DEVICE_ID_LOONGSON_OHCI            0x7a24
>> +#define PCI_DEVICE_ID_LOONGSON_PCIE_X8         0x7a29
> Hi Tiezhu,
>
> Thanks for the patch - however it is preferred to provide new PCI definitions
> along with the drivers that use them. They don't provide any useful value
> without drivers that use them.

Hi Andrew,

Thanks for your reply. This is the first step of the Loongson kernel team,
we will submit other related individual driver patches step by step in the
near future, these small patches make an easily understood change that can
be verified by reviewers.

Thanks,

Tiezhu Yang

>
> Thanks,
>
> Andrew Murray
>
>> +
>>   #endif /* _LINUX_PCI_IDS_H */
>> -- 
>> 2.1.0
>>
>>