Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp7890749ybn; Mon, 30 Sep 2019 23:08:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIrxnzV4Me9BpXC5CFQ3kJJ45aXxTFjEdA5MJg7UTwqpfupUvXJj7or/GeJ+ao4lGxAPHm X-Received: by 2002:a17:906:3190:: with SMTP id 16mr2561047ejy.202.1569910135107; Mon, 30 Sep 2019 23:08:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569910135; cv=none; d=google.com; s=arc-20160816; b=Ti6o96BWvlZJgGoN4Yu+H2M9rEBCALChJsVwWALwvFo0cOMh04uXxL6J3cyNtHVHa/ mSgbEd5aTFXVuCtmSOwxiNHSXgVF3JiFL02F5/+QnWEEaJ10VjkjXfG1pqnU4aedfLCP nchVOTr9C95bBGwdo77uk5u+r0JgAxrQNt9zlht4NibNd7nMX4iOlFPzZ+ZOsIZt6F+j +F4RvQXKmemgfxFk2DWJrs5WnmVqkX/WgWdck3xTVRViAlMbByD0DpBbHMiWStzFd+8E 2tRKD3WQ6ZuY8IaJvQfZl6MmYaq9MnW7IkMaxEVgdQ50JUlS7UtS1lgg91SLTcqMnIiT 8aBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EGjEE5FSc2okQiViVEba1QTj+cW2TQAUUAIUHI5RXtU=; b=m8dnlYqiQKZQCcYmWC15xR8pvUAJ5OtZSfjPSzfDS5svCJAM2U1jOow4LjEGsK7wkE 33W8PTg9uV/4LE0fKE6+a1VH1BvaPXk003mq2hqaCrfyoAQy7uPqvs8pwPiPQ0eGIxlP bmFJ9EIHIcahnmhfmVfnax22QY2/umgtGfuxxjuc2D+9A0A5VsCcBELUVFhw1AWy7vcW SIyLy6Q86wSJbhJdVjyUR82/ibYdGS/ZHN1X4Cy45bq2NjBvuC143Ed5S40hE3MSj0Hn ukW0yJhO40R7uenui59tFslAYwsMNFrR0W+oZvzNbNjI5KnsMV27UgmhkmKHdgS0R/Pq biPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si8326939eju.333.2019.09.30.23.08.28; Mon, 30 Sep 2019 23:08:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732515AbfJAGIS (ORCPT + 99 others); Tue, 1 Oct 2019 02:08:18 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:55471 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732347AbfJAGIS (ORCPT ); Tue, 1 Oct 2019 02:08:18 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iFBKY-0005n4-S4; Tue, 01 Oct 2019 08:08:14 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1iFBKW-0006Ne-R5; Tue, 01 Oct 2019 08:08:12 +0200 From: Oleksij Rempel To: Andrew Lunn , Florian Fainelli , Heiner Kallweit Cc: Oleksij Rempel , Pengutronix Kernel Team , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] net: phy: at803x: remove probe and struct at803x_priv Date: Tue, 1 Oct 2019 08:08:11 +0200 Message-Id: <20191001060811.24291-4-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191001060811.24291-1-o.rempel@pengutronix.de> References: <20191001060811.24291-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org struct at803x_priv is never used in this driver. So remove it and the probe function allocating it. Suggested-by: Heiner Kallweit Signed-off-by: Oleksij Rempel --- drivers/net/phy/at803x.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 42492f83c8d7..e64f77e152f4 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -63,10 +63,6 @@ MODULE_DESCRIPTION("Atheros 803x PHY driver"); MODULE_AUTHOR("Matus Ujhelyi"); MODULE_LICENSE("GPL"); -struct at803x_priv { - bool phy_reset:1; -}; - struct at803x_context { u16 bmcr; u16 advertise; @@ -232,20 +228,6 @@ static int at803x_resume(struct phy_device *phydev) return phy_modify(phydev, MII_BMCR, BMCR_PDOWN | BMCR_ISOLATE, 0); } -static int at803x_probe(struct phy_device *phydev) -{ - struct device *dev = &phydev->mdio.dev; - struct at803x_priv *priv; - - priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) - return -ENOMEM; - - phydev->priv = priv; - - return 0; -} - static int at803x_config_init(struct phy_device *phydev) { int ret; @@ -367,7 +349,6 @@ static struct phy_driver at803x_driver[] = { /* ATHEROS 8035 */ PHY_ID_MATCH_EXACT(ATH8035_PHY_ID), .name = "Atheros 8035 ethernet", - .probe = at803x_probe, .config_init = at803x_config_init, .set_wol = at803x_set_wol, .get_wol = at803x_get_wol, @@ -380,7 +361,6 @@ static struct phy_driver at803x_driver[] = { /* ATHEROS 8030 */ PHY_ID_MATCH_EXACT(ATH8030_PHY_ID), .name = "Atheros 8030 ethernet", - .probe = at803x_probe, .config_init = at803x_config_init, .link_change_notify = at803x_link_change_notify, .set_wol = at803x_set_wol, @@ -394,7 +374,6 @@ static struct phy_driver at803x_driver[] = { /* ATHEROS 8031 */ PHY_ID_MATCH_EXACT(ATH8031_PHY_ID), .name = "Atheros 8031 ethernet", - .probe = at803x_probe, .config_init = at803x_config_init, .set_wol = at803x_set_wol, .get_wol = at803x_get_wol, -- 2.23.0