Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Hanna Hawa <hhhawa@amazon.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v4 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Topic: [PATCH v4 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Index: AQHVeCVrgaUXL1IS7EiUioDc+15NJQ==
Date:   Tue, 1 Oct 2019 06:56:58 +0000
Message-ID: <20191001065649.a6454bh4ncgdpigf@rric.localdomain>
References: <20190923191741.29322-1-hhhawa@amazon.com>
 <20190923191741.29322-2-hhhawa@amazon.com> <20190930145046.GH29694@zn.tnic>
In-Reply-To: <20190930145046.GH29694@zn.tnic>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c0cf36b6-83a9-4466-de7a-08d7463c8dca
x-ms-traffictypediagnostic: MN2PR18MB2414:
x-microsoft-antispam-prvs: <MN2PR18MB241457A9A4BEC4AF95A87168D99D0@MN2PR18MB2414.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 0177904E6B
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(376002)(39860400002)(346002)(396003)(199004)(189003)(4326008)(64756008)(66946007)(66476007)(66556008)(66446008)(66066001)(305945005)(71200400001)(71190400001)(256004)(6916009)(7736002)(7416002)(6246003)(3846002)(9686003)(1076003)(102836004)(6116002)(99286004)(8676002)(8936002)(2906002)(6512007)(6436002)(53546011)(76176011)(81156014)(386003)(81166006)(52116002)(25786009)(11346002)(316002)(26005)(54906003)(478600001)(14454004)(6506007)(476003)(86362001)(5660300002)(186003)(229853002)(6486002)(446003)(486006);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2414;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8KFVQ8AV9AGyccUioWfX2NgeFLMI0VUeHnGJ3NrgjxlCW4nhzOEie9Eskb8qM+7wz+UY4BpJjmj/HmvFeHdAk84PKNw+Zda2PDSNk7QRRzKSPX2lFTknVY9N5WuVKeCBaLNcZUT0/6mtCDaFGPUKREwy+4a8gAJGs6c8e4BssfWmcMzQFmKlJgiQngwlRe/njwGg2Ucbv8sZXyCFVqy2xaAnwnHVue5ERY2xS0Jbcl2L7gN2NWZLX07ocy/HBCWi8TyQmL+Ay4d1z9qOjJgFe/Q3hDupVE9HwwoowR//h5tUorihEnHa/yWrlOmr2svSxdUGCX+34QOyYls2ZXdzLRWiKONIzxPM+vi5Xw35eeHPLQtwzl2bNiUJXYVgD/mhfxr8bO7bQtsWY98GnN11sObCww5pHoUk7wUCRh8/yF4=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B011E369A5477F4098887569C9292363@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c0cf36b6-83a9-4466-de7a-08d7463c8dca
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2019 06:56:59.2446
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EnHasRR1L1wnmXDUHIhCaxHaJ0IwZgJjp94xpTlyTtyGE8Tm+HkQumUnt7liPh0EKh9xSpuWaQOD0M+gEDCEtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2414
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-01_03:2019-09-30,2019-10-01 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30.09.19 16:50:46, Borislav Petkov wrote:
> ----------------------------------------------------------------------
> On Mon, Sep 23, 2019 at 08:17:40PM +0100, Hanna Hawa wrote:
> > +void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
> > +			int inst_nr, int block_nr, const char *msg)
> > +{
> > +	__edac_device_handle_ce(edac_dev, 1, inst_nr, block_nr, msg);
> > +}
> > +EXPORT_SYMBOL_GPL(edac_device_handle_ce);
>=20
> Eww, I don't like that: exporting the function *and* the __ counterpart.
> The user will get confused and that is unnecessary.

It is *not* the counterpart. The __* version already has the
additional count argument in. There are 2 patches:

1) introduce new function __edac_device_handle_ce/ue() including the
   *_count() inline functions, but keep the old symbols (note the
   count=3D1 parameter).

2) remove old symbol edac_device_handle_ce/ue() and replace it with an
   inline function to use the counterpart symbol too.

The first patch only adds functionality but keeps the abi. Thus it
makes a backport easier. The 2nd switches completely to the new
function.

-Robert