Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8012324ybn; Tue, 1 Oct 2019 01:36:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqyW6xesIp96rMeJoJZoALRZhHESGTQ+rovWOwDX34XQ7vPMQOe/QiO0PPSjXjR7dFK7QAYv X-Received: by 2002:a17:906:c282:: with SMTP id r2mr21731218ejz.207.1569918984035; Tue, 01 Oct 2019 01:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569918984; cv=none; d=google.com; s=arc-20160816; b=wArz0WAkGUjv96noPQu04i8IPANIvF06QZzYAcc9rsWMaFVnY7G7uPNhPAdmGzhwfb hXz1R8ydWDcVuSzGR34zXLGW3s2Fmp9aUyp7xDYwqM0jaaKMLuhdn5ArtvLuUn8PL4bO c2UghCEDUdQwiG3v05xHMV7QgYdb58yUH/xe0BizrFb6S6yJKXy9mGqKepl2HRCCebaW yj52PPyY+8ALkaSRGQf9S5g56sor8sXIgljEOPb3Oe0lHZboHN855qs6Dj59pYA/yoUH UxlzRVui83yBP8sGbsFY5XpAL4U5uEDY6WOkybvGSpPQrMPLJs+dq64F1/POHQBq3g4c sD4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8omf2Ond+HjWgVnZgR3IZ7lalr9H6LO8bfe8Bs9TbPM=; b=gMIbAu48ZW4W8K0BRQaQqJm6fs0PaGBoHO7WrAcWUePS2TnbkLI3JmSDrdtvolebJt ytCNVobGy2npTecLvizDFdmyofNtf526VIBYJutISCEdttfYuMorA9IYbncCEv12wDIV nDK5r81sjRzZFPDkiZa+V0LJWFxcNAVZfajEZTrQ3Q72niDzS8IrD1ehIPDwqTkzgjC+ W9J6erP0eGv6g8mYoEqKrZb7fiXpXIZsp8pGL14MJhvAyF5ka0Vwq08dJlQgpodHQeiM d/SzzKiA3Xpyjiux5HMqi+JSz+N3DyERXHV6yIVfq5V1ni15dvOpjiYV6ZRmPLkmKyTs mcwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=VaEc2mCS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1si8464493ede.268.2019.10.01.01.35.59; Tue, 01 Oct 2019 01:36:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=VaEc2mCS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733098AbfJAIcq (ORCPT + 99 others); Tue, 1 Oct 2019 04:32:46 -0400 Received: from mail.skyhub.de ([5.9.137.197]:48128 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbfJAIcq (ORCPT ); Tue, 1 Oct 2019 04:32:46 -0400 Received: from zn.tnic (p200300EC2F0A2D0084604B8D68D34A5E.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:2d00:8460:4b8d:68d3:4a5e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 176B21EC03AD; Tue, 1 Oct 2019 10:32:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1569918765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=8omf2Ond+HjWgVnZgR3IZ7lalr9H6LO8bfe8Bs9TbPM=; b=VaEc2mCSAFRpSLy/fkc5shomJWzgGFT0ONazx9MCWEXokTZZBkJesR0DKxms8UL2wCDdmu M33jqaXvDf/2GvttfnHvaLlknCnhi4bwKKMDEOdkmJDvcpjY4F7hHehHfhyyxrTdv24Zjy YBOXQ7mIMQBGD2AGS5yg0UfvtvqV0Hs= Date: Tue, 1 Oct 2019 10:32:42 +0200 From: Borislav Petkov To: Robert Richter Cc: Hanna Hawa , "mchehab@kernel.org" , "james.morse@arm.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dwmw@amazon.co.uk" , "benh@amazon.com" , "ronenk@amazon.com" , "talel@amazon.com" , "jonnyc@amazon.com" , "hanochu@amazon.com" Subject: Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors Message-ID: <20191001083242.GA5390@zn.tnic> References: <20190923191741.29322-1-hhhawa@amazon.com> <20190923191741.29322-2-hhhawa@amazon.com> <20190930145046.GH29694@zn.tnic> <20191001065649.a6454bh4ncgdpigf@rric.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191001065649.a6454bh4ncgdpigf@rric.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 06:56:58AM +0000, Robert Richter wrote: > It is *not* the counterpart. The __* version already has the... Lemme cut to the chase: "Make the main workhorse the "count" functions which can log a @count of errors. Have the current APIs edac_device_handle_{ce,ue}() call the _count() variants and this way keep the exported symbols number unchanged." I want to see exactly *two* pairs of functions: edac_device_handle_{ce,ue}_count - logs a @count of errors edac_device_handle_{ce,ue} - logs a single error Not three pairs. I.e., the "__" versions are not needed. > The first patch only adds functionality but keeps the abi. Thus it > makes a backport easier. Works just the same with my version - single backport. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette