Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190812150452.27983-1-ard.biesheuvel@linaro.org> <20190812150452.27983-5-ard.biesheuvel@linaro.org>
In-Reply-To: <20190812150452.27983-5-ard.biesheuvel@linaro.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 1 Oct 2019 10:51:39 +0200
Message-ID: <CAMuHMdXY5UH4KhcaNVuxa8-+GN-4bjyvCd0wzPYuFBY5Ch=fNA@mail.gmail.com>
Subject: Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Narendra K <Narendra.K@dell.com>
Cc:     linux-efi <linux-efi@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        James Morse <james.morse@arm.com>,
        Mario Limonciello <mario.limonciello@dell.com>,
        Xiaofei Tan <tanxiaofei@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ard, Narendra,

On Mon, Aug 12, 2019 at 5:07 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> From: Narendra K <Narendra.K@dell.com>
>
> System firmware advertises the address of the 'Runtime
> Configuration Interface table version 2 (RCI2)' via
> an EFI Configuration Table entry. This code retrieves the RCI2
> table from the address and exports it to sysfs as a binary
> attribute 'rci2' under /sys/firmware/efi/tables directory.
> The approach adopted is similar to the attribute 'DMI' under
> /sys/firmware/dmi/tables.
>
> RCI2 table contains BIOS HII in XML format and is used to populate
> BIOS setup page in Dell EMC OpenManage Server Administrator tool.
> The BIOS setup page contains BIOS tokens which can be configured.
>
> Signed-off-by: Narendra K <Narendra.K@dell.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks, this is now commit 1c5fecb61255aa12 ("efi: Export Runtime
Configuration Interface table to sysfs").

> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -180,6 +180,19 @@ config RESET_ATTACK_MITIGATION
>           have been evicted, since otherwise it will trigger even on clean
>           reboots.
>
> +config EFI_RCI2_TABLE
> +       bool "EFI Runtime Configuration Interface Table Version 2 Support"
> +       help
> +         Displays the content of the Runtime Configuration Interface
> +         Table version 2 on Dell EMC PowerEdge systems as a binary
> +         attribute 'rci2' under /sys/firmware/efi/tables directory.
> +
> +         RCI2 table contains BIOS HII in XML format and is used to populate
> +         BIOS setup page in Dell EMC OpenManage Server Administrator tool.
> +         The BIOS setup page contains BIOS tokens which can be configured.
> +
> +         Say Y here for Dell EMC PowerEdge systems.

A quick Google search tells me these are Intel Xeon.
Are arm/arm64/ia64 variants available, too?
If not, this should be protected by "depends on x86" ("|| COMPILE_TEST"?).

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds