Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Hanna Hawa <hhhawa@amazon.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v4 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Topic: [PATCH v4 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Index: AQHVeD0w3a8Q6Y9qUkqSALBVLRrJbQ==
Date:   Tue, 1 Oct 2019 09:47:07 +0000
Message-ID: <20191001094659.5of5ul2tof6s75px@rric.localdomain>
References: <20190923191741.29322-1-hhhawa@amazon.com>
 <20190923191741.29322-2-hhhawa@amazon.com> <20190930145046.GH29694@zn.tnic>
 <20191001065649.a6454bh4ncgdpigf@rric.localdomain>
 <20191001083242.GA5390@zn.tnic>
In-Reply-To: <20191001083242.GA5390@zn.tnic>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 885747b6-5664-4e81-6ca8-08d746545292
x-ms-traffictypediagnostic: MN2PR18MB2751:
x-microsoft-antispam-prvs: <MN2PR18MB2751BD926E7103014A0A7BD8D99D0@MN2PR18MB2751.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-forefront-prvs: 0177904E6B
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(199004)(189003)(6512007)(9686003)(305945005)(6486002)(316002)(1076003)(64756008)(66446008)(66556008)(54906003)(66946007)(4326008)(66476007)(6246003)(486006)(6436002)(476003)(86362001)(478600001)(7736002)(7416002)(229853002)(446003)(66066001)(11346002)(99286004)(6116002)(3846002)(8936002)(8676002)(81156014)(81166006)(102836004)(71190400001)(14454004)(53546011)(6506007)(386003)(2906002)(6916009)(25786009)(52116002)(71200400001)(76176011)(26005)(256004)(186003)(5660300002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2751;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Te52llMjrpj5jyW0WAH+DKekQutyuQuHhPBqVbibVJuot8/Xt0j1Es9FmLjR24bXbVig053p5RGVnAGm6cvpYRjIxeAFrVE7HEXx5A3KyTinlA/7sXN2FerPj65LueC9bHKiv6w3T62uRZ0DxhHjoON2ILeIIm99b0oachV7mR9jWBDKzCCFF2PSdswC+bsd3om7FHOa7L0yL4wakU+nvkHneaggrZUEJEesm94a4PUoMnNyGHvu9fDAXv3lAGR+9fcJocWVhsDQ7swQnvo/NYNbNaX0Ru78PIZbXA7BqQTzGEolQiECwHPPEomverfZtBhQdBzCIwsRFJpZP66yRSa2y4/XR9mWOXRyKgilhEw0J6UPZJw7/mbXBcu/Bf04B+1AwB3Pnk1189a8L99qPhDsZVw0gdRMViiwQHwYhr8=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F96B9A032DD11B43B46C5D4C8E8EA8CE@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 885747b6-5664-4e81-6ca8-08d746545292
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2019 09:47:07.5108
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t4/6oMSv+u/VvBaq8VcuWsfs0lkZxYHvH8xS+zvVcu4UIyr5YwDrBO9kzdcdJkc+HyeUNRhKy5fENdUzKiwsPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2751
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-01_05:2019-10-01,2019-10-01 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01.10.19 10:32:42, Borislav Petkov wrote:

> ----------------------------------------------------------------------
> On Tue, Oct 01, 2019 at 06:56:58AM +0000, Robert Richter wrote:
> > It is *not* the counterpart. The __* version already has the...
>=20
> Lemme cut to the chase:
>=20
> "Make the main workhorse the "count" functions which can log a @count
> of errors. Have the current APIs edac_device_handle_{ce,ue}() call
> the _count() variants and this way keep the exported symbols number
> unchanged."
>=20
> I want to see exactly *two* pairs of functions:
>=20
> edac_device_handle_{ce,ue}_count	- logs a @count of errors
> edac_device_handle_{ce,ue}		- logs a single error
>=20
> Not three pairs. I.e., the "__" versions are not needed.
>=20
> > The first patch only adds functionality but keeps the abi. Thus it
> > makes a backport easier.
>=20
> Works just the same with my version - single backport.

If you move to static inline for edac_device_handle_{ce,ue} the
symbols vanish and this breaks the abi. That's why the split in two
patches.

Your comment to not have a __ version as a third variant of the
interface makes sense to me. But to keep ABI your patch still needs to
be split. The first patch still must contain symbols for
edac_device_handle_{ce,ue}. I am not sure if ABI compatability is
something we want to make easier here. I personally like the approach.

-Robert