Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8090625ybn; Tue, 1 Oct 2019 03:05:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIwtO8Jsvmxz0u+6u+ldKmkeju3J8MJoB1i2+VpkwxqPs91lrDJTV3rBFPjStx3lKB0AjO X-Received: by 2002:aa7:dc4b:: with SMTP id g11mr24881002edu.70.1569924346911; Tue, 01 Oct 2019 03:05:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569924346; cv=none; d=google.com; s=arc-20160816; b=yaf5THoiPfZ0zkqRo8NX/kTrFS/RuMXpBnCufbjniyhHCPJianuqJsJvoyMUVVStor uhbtlcRVPcPzkn0BdhwUDorh5aQGUeF/PTIW7rpkLigyj8gujRQ7KttJI3ZFNh/hEheV w/Kih8hBOKyLtlyNhPFFhlIzND3JfDlAbLpc20DnqSLGR8dcaMgDadfqw6lsUATvp1Ld KuOGI4v/6nTDZyuXP1fpDfkU78bgHrhSTK9beP4bvNN5O7ypzA+TsC1T5ci16Vq2qJ8z +X9IUnwBEwG03+2RbUOEnF1gy6JZ4cO85D7hfUkQvcl6OynINQ5X1ZQZT89Gp4uUYEU/ Ez2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=jfEC1TGjCjlUPWaqoa/5iDRLy0eOrlVNBmTC/RZtswg=; b=wCGE4grbanQ8n/yN0XZT2z0tDVROImxSD2g8m/MCDgCdOKCV3eQG92lW/0Xm4N4PUM k3LYwIx4XE+vwNpUvnLxdnXDMu9mP40bq2gfo2tgqzU2VT8ZpkZZn068LaJw+JjSvlSy ipmbMKTiHZ4ErI1ZYBcSwJcE7936cI6s1KZLpYRuVehl+1gFJM4gVbyLn0vb2q+rT9Op 2nprG9fc5RzGqo8JUHBVycg/XvAGk6U0wzUD2KPe24jyo/9A3vqoGB04CV1xYRqoC1ob THVK9PXFnfnRyjnfQBej6NpUpnNNHfaaMw2ZFf50hPMHD9560YTveRRkMlt87oCwL9xZ bFrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=FgFy2yn9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si9266529edc.224.2019.10.01.03.05.20; Tue, 01 Oct 2019 03:05:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=FgFy2yn9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729503AbfJAKDd (ORCPT + 99 others); Tue, 1 Oct 2019 06:03:33 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:36429 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727188AbfJAKDd (ORCPT ); Tue, 1 Oct 2019 06:03:33 -0400 Received: by mail-lf1-f65.google.com with SMTP id x80so9403928lff.3 for ; Tue, 01 Oct 2019 03:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jfEC1TGjCjlUPWaqoa/5iDRLy0eOrlVNBmTC/RZtswg=; b=FgFy2yn9Vseh4V6b9FZsBr3u//+h6GwKFTqjNjIbcWJ0mQaiQGTSiWRyVPO45NIUDA +kv/fjRM0CDNs1rfcmp0D/jYCNq+AmiTjx7BXAvYmzxUk7nyzEIjh9Hb0oLtdyYlmc8N Uu+43KrFKPApQMGy0aT/d0tG5v2NIftz3uBiUcule0IGt35ijHdj78a0X00ycX4GLRQC aSTSWo/+hbV18WQ631WP8I2b395r4XwHm88odG30ryQoqka/S3USYW5D1KAKybhNtUqz Os/f8U7dEe46GTDepjDbV2mTb4yOHBK5reOhbnITEQIoJfeboQW1gNb6y8PWK4UwMhev qC3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jfEC1TGjCjlUPWaqoa/5iDRLy0eOrlVNBmTC/RZtswg=; b=h4+A7vrGU93VaAGCiqQcZUjgrokOYU5ZbX/WZvxF55XOhjo1qoDhaaTNVLQU52ZQtp qqOPrmJ5UEv/wBXdck8x3b+j4G8iWlcQXODOEcmOXS+cCjKkZUHCxqAK7+vcEGt+gggo NmngBTk0JlkC0mTOwH8HC+6RLFfy6BGHOwRL89CNLLSFFLnBg7ESD3oaJJAkm7YLAae7 B+QHK/uAURwYuGVFMefYeAiTAKSv5xDsEHHI91C0xfOhHCPOkIhLyoM4/imqL9h8IEJD d6e5FF1NpA07KP2hZj7a9SWsket8KazNWHUqmO3wNUJYVueOZ0mNWCxpOmBnyiFYrd8j Hbow== X-Gm-Message-State: APjAAAWwGAoWvLrEn+9bXvYf5+ZiDDFcs+bMCedguZzyPU+DamkjhZaD uQsO6sWmFJOVM2VZ7NmX3SUvWJNb6Sd5z1X6pXGSKg== X-Received: by 2002:a19:c6d5:: with SMTP id w204mr13871509lff.53.1569924211487; Tue, 01 Oct 2019 03:03:31 -0700 (PDT) MIME-Version: 1.0 References: <20190828103229.191853-1-maco@android.com> <20190904194901.165883-1-maco@android.com> <20190930082412.GA9460@infradead.org> In-Reply-To: <20190930082412.GA9460@infradead.org> From: Martijn Coenen Date: Tue, 1 Oct 2019 12:03:20 +0200 Message-ID: Subject: Re: [PATCH v2] loop: change queue block size to match when using DIO. To: Christoph Hellwig , Jens Axboe , Ming Lei Cc: linux-block , LKML , Greg KH , kernel-team@android.com, Narayan Kamath , Dario Freni , Nikita Ioffe , Jiyong Park , Martijn Coenen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 30, 2019 at 10:24 AM Christoph Hellwig wrote: > > Looks fine: > > Reviewed-by: Christoph Hellwig Thanks Christoph! Jens, Ming, are you also ok with taking this?