Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Hanna Hawa <hhhawa@amazon.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
        "benh@amazon.com" <benh@amazon.com>,
        "ronenk@amazon.com" <ronenk@amazon.com>,
        "talel@amazon.com" <talel@amazon.com>,
        "jonnyc@amazon.com" <jonnyc@amazon.com>,
        "hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v4 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Topic: [PATCH v4 1/2] edac: Add an API for edac device to report for
 multiple errors
Thread-Index: AQHVeEaAgxYDdzoLUUm+D1Y78e5zpw==
Date:   Tue, 1 Oct 2019 10:53:47 +0000
Message-ID: <20191001105339.5tbdw2mrb2uwit6j@rric.localdomain>
References: <20190923191741.29322-1-hhhawa@amazon.com>
 <20190923191741.29322-2-hhhawa@amazon.com> <20190930145046.GH29694@zn.tnic>
 <20191001065649.a6454bh4ncgdpigf@rric.localdomain>
 <20191001083242.GA5390@zn.tnic>
 <20191001094659.5of5ul2tof6s75px@rric.localdomain>
 <20191001102539.GB5390@zn.tnic>
In-Reply-To: <20191001102539.GB5390@zn.tnic>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7af98009-8590-4736-9068-08d7465da2f1
x-ms-traffictypediagnostic: MN2PR18MB3261:
x-microsoft-antispam-prvs: <MN2PR18MB32618F80BEDEB6900E57939AD99D0@MN2PR18MB3261.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4714;
x-forefront-prvs: 0177904E6B
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(346002)(39860400002)(136003)(376002)(366004)(189003)(199004)(186003)(76176011)(229853002)(6486002)(386003)(52116002)(66476007)(2906002)(102836004)(64756008)(66066001)(66556008)(66446008)(66946007)(6512007)(99286004)(26005)(478600001)(9686003)(53546011)(54906003)(25786009)(14454004)(6246003)(316002)(6506007)(3846002)(6116002)(6436002)(4326008)(256004)(7416002)(8936002)(86362001)(305945005)(486006)(6916009)(5660300002)(7736002)(8676002)(446003)(71190400001)(81166006)(71200400001)(11346002)(1076003)(476003)(4744005)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB3261;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: kk0MqzBpDenGoQ5gHMDgyv13LSILSIik9cu6ThggC4O4Vgz9ZuWw9Zv9VNl5DIv/gK4Nx/sIm2rmxelQaaNSPQNs/+WQ1nolnQv1vep5DnOMtzt18IezipFgDfy8PvMx0k6t7bVz+dxww+JlSHch4a98s+r/cvd8EeaygOMie5UrZ5ELdo4CQ9V4l2IxzyfaKBuV7IUihISMtemebIzYuN0Xcw0JIA40nJXExbArfnyYiE2X1nN+PHvaGICYZVX9XEHZPA9EkeJEJvH0m7Km9igxv2xdmI8w8OnS9iB6Nkfs9zEbBTP9U2AfDJGoF6JNDbjdOEnqwQRkNLZAyMBdu8NSBCiU/NO378sBAbdoJ+1mtz12B+6XnzvRXdPC8mqoL+dw7RPpl/EIPgOmCTRMFeB2eLE+VNs5yZYpmkarv0o=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8F39A9DAD79F704DBBF0FC0571D1A1D0@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7af98009-8590-4736-9068-08d7465da2f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2019 10:53:48.0544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6pyrwfGd1IhF6UvdX2iA00qVkH/buzO4q4+kmF6idJdtkbrlogBAHkNkvYTAsvs9XMT3YUfowbrufzK3r8fa8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3261
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-01_05:2019-10-01,2019-10-01 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01.10.19 12:25:39, Borislav Petkov wrote:
> On Tue, Oct 01, 2019 at 09:47:07AM +0000, Robert Richter wrote:
> > If you move to static inline for edac_device_handle_{ce,ue} the
> > symbols vanish and this breaks the abi. That's why the split in two
> > patches.
>=20
> ABI issues do not concern upstream. And that coming from me working at a
> company who dance a lot to make ABI happy.
>=20
> Also, I'm missing the reasoning why you use the ABI as an argument at
> all: do you know of a particular case where people are thinking of
> backporting this or this is all hypothetical.
>=20
> > Your comment to not have a __ version as a third variant of the
> > interface makes sense to me. But to keep ABI your patch still needs to
> > be split.
>=20
> Not really - normally, when you fix ABI issues with symbols
> disappearing, all of a sudden, you add dummy ones so that the ABI
> checker is happy.

Let's go with a single patch then and the function naming you
suggested before.

Thanks,

-Robert