Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1 4/4] usb: host: xhci-tegra: Switch to use %ptT
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
References: <20190104193009.30907-1-andriy.shevchenko@linux.intel.com>
 <20190104193009.30907-4-andriy.shevchenko@linux.intel.com>
 <20191001115640.GJ32742@smile.fi.intel.com>
From:   Mathias Nyman <mathias.nyman@intel.com>
Message-ID: <99fa90e8-3188-6781-dcbd-89e29e8509eb@intel.com>
Date:   Tue, 1 Oct 2019 15:20:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191001115640.GJ32742@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1.10.2019 14.56, Andy Shevchenko wrote:
> On Fri, Jan 04, 2019 at 09:30:09PM +0200, Andy Shevchenko wrote:
>> Use %ptT instead of open coded variant to print content of
>> time64_t type in human readable format.
> 
> Any comments on this?

Untested, but looks ok to me.

xhci-tegra.c is written by Thierry Reding, so its more up to him

> 
>>
>> Cc: Mathias Nyman <mathias.nyman@intel.com>
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Cc: Jonathan Hunter <jonathanh@nvidia.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>   drivers/usb/host/xhci-tegra.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
>> index 938ff06c0349..ed3eea3876e2 100644
>> --- a/drivers/usb/host/xhci-tegra.c
>> +++ b/drivers/usb/host/xhci-tegra.c
>> @@ -820,7 +820,6 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
>>   	const struct firmware *fw;
>>   	unsigned long timeout;
>>   	time64_t timestamp;
>> -	struct tm time;
>>   	u64 address;
>>   	u32 value;
>>   	int err;
>> @@ -925,11 +924,8 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
>>   	}
>>   
>>   	timestamp = le32_to_cpu(header->fwimg_created_time);
>> -	time64_to_tm(timestamp, 0, &time);
>>   
>> -	dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
>> -		 time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
>> -		 time.tm_hour, time.tm_min, time.tm_sec);
>> +	dev_info(dev, "Firmware timestamp: %ptT UTC\n", &timestamp);
>>   
>>   	return 0;
>>   }
>> -- 
>> 2.19.2
>>
>