Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8292112ybn; Tue, 1 Oct 2019 06:11:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXZYuKSDdeUUVeCru1lRw80ztN4Jr7ndMRkK6QrlL+K7ux3uo4cvKzjr82OsgotVI6T1oJ X-Received: by 2002:aa7:df8e:: with SMTP id b14mr3043704edy.65.1569935515511; Tue, 01 Oct 2019 06:11:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569935515; cv=none; d=google.com; s=arc-20160816; b=rTzszR8S0nlN0VVyPTSRFwjtUTSw0udZUKaKRDsTlKnCw7v1xANlgZTn9XI81Eglro X29TUpuDoNOITPjelgeDyx+I6TPxOENk7cKEvP1lEtg0nF5B8dSUk5sZy5k1ATqkVMR5 dkuo61LGQaHvoaNUw04bwP4X+jA+r2yVL1tULIthSBxUVnUuM3RqXsYlb6dEZzJDgWUH pqU4L9TuE7C0z0NeZ9Av0UsHvIdpBvUyaxfqNwpvfVjg+KpUqfOiKa8iA0qpy7Jivu7B OH9RjPIqttU43kByPpy7QP92NdKO3u64je4jxgMe10ygOKb9mQaifhFQA+HLeqN+G/wX YQow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BVHkE308PfTMtTyFD6F3VEq3t63vA3WR0beBiVycBYg=; b=aPjg76DcTp9KHKoapES9R+bazivcnQkrqpw1fmLVRejlmxsznUmqQIPe+297+cG7Pa 6/5SRqM4lWs1yBvngQFfpikGLcjs42cNAiMdGkkYx6pnD3XYZoyM2GD3H8Ft6NXZv9wl Pn/+Kr6V579nV7CTDr7VLRRL1xyrjXuLxfXzo4Px/vtuyYidHLnvALRz0YrGmGn9kSaz tfp68bK8/MhFHYrbfXNGmMVfM0DeFlDdsBv/GhqfC5a/Rn3acRRmBKhK+kEQSICYG8c2 2C6eRxzIJiI1RQ2bg7Et6WagDBuw3QCJ1eWWQ7l/e9cvPEC9IaSG1Gfvds2A9v2DpxW5 kZWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b33si9611366edc.265.2019.10.01.06.11.22; Tue, 01 Oct 2019 06:11:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbfJANJL (ORCPT + 99 others); Tue, 1 Oct 2019 09:09:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:30595 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfJANJK (ORCPT ); Tue, 1 Oct 2019 09:09:10 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 06:09:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,571,1559545200"; d="scan'208";a="205061262" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 01 Oct 2019 06:09:06 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 01 Oct 2019 16:09:05 +0300 Date: Tue, 1 Oct 2019 16:09:05 +0300 From: Mika Westerberg To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Andreas Noever , Michael Jamet , Yehezkel Bernat , Rajmohan Mani , Nicholas Johnson , Lukas Wunner , Alan Stern , Mario.Limonciello@dell.com, Anthony Wong , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 17/22] thunderbolt: Add initial support for USB4 Message-ID: <20191001130905.GO2714@lahna.fi.intel.com> References: <20191001113830.13028-1-mika.westerberg@linux.intel.com> <20191001113830.13028-18-mika.westerberg@linux.intel.com> <20191001124748.GH2954373@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191001124748.GH2954373@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 02:47:48PM +0200, Greg Kroah-Hartman wrote: > > - Thunderbolt Controller driver. This driver is required if you > > - want to hotplug Thunderbolt devices on Apple hardware or on PCs > > - with Intel Falcon Ridge or newer. > > + USB4 (Thunderbolt) driver. USB4 is the public spec based on > > + Thunderbolt 3 protocol. This driver is required if you want to > > + hotplug Thunderbolt and USB4 compliant devices on Apple > > + hardware or on PCs with Intel Falcon Ridge or newer. > > Wait, did "old" thunderbolt just get re-branded as USB4? Not but the driver started supporting USB4 as well :) USB4 is pretty much public spec of Thunderbolt 3 but with some differences in register layouts (this is because Thunderbolt uses some vendor specific capabilities which are now moved to more "standard" places). > Because if I have an "old" laptop that needs Thunderbolt support, how am > I going to know it is now called USB4 instead? Well the Kconfig option tries to have both names there: tristate "USB4 (Thunderbolt) support" and then USB4 (Thunderbolt) driver. USB4 is the public spec based on Thunderbolt 3 protocol. This driver is required if you want to hotplug Thunderbolt and USB4 compliant devices on Apple hardware or on PCs with Intel Falcon Ridge or newer. and the Kconfig option is still CONFIG_THUNDERBOLT. I know this is confusing but I don't have better ideas how we can advertise both. I borrowed this "format" from firewire. > Shouldn't there just be a new USB4 option that only enables/builds the > USB4 stuff if selected? Why would I want all of this additional code on > my old system if it's not going to do anything at all? USB4 devices are backward compatible with Thunderbolt 3 so you should be able to plug in USB4 device to your old Thunderbolt 3 laptop for example. It goes the other way as well. Some things are optional but for example USB4 hubs must support also Thunderbolt 3. Does that clarify?