Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8316452ybn; Tue, 1 Oct 2019 06:30:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzjnPfzNAO0YMPWlDXIy+t5OwZWVjEXMrzyP/wOjXxBButh3j8R5tjJCB+PLIXp5FvIuIf X-Received: by 2002:a19:c14a:: with SMTP id r71mr14655880lff.55.1569936649152; Tue, 01 Oct 2019 06:30:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569936649; cv=none; d=google.com; s=arc-20160816; b=V8zE9L/i3yNQpqKPj0TaxvgBCMezAofEgFRdzxpRg18TdI3ggb0r+mqXwACiVhYznP 2l+AsywF1M6iLOItEhoyrJgTVhUaKqNPiT+Xp/4iNMEakIV34+pR9Nbx/pYs/b74tZla bD2qCUMg7UzGSegSm3pSveADBI65mkiEV1cJG6Tqm+eFDqdBZ37TLH4Xqw05DjIZQRCP SG2I4h9aApqb9CrCwXYayoFo15Vu53T6Afc0JXWTb58wP+hAaSBYAAvePLeLOyoYekEK /Z0ShM03MQifZEzT8sIBsMwmJ6Qf3TG4wv2kW+6qyPOakWv6h/8pjWy+9sz4V2Xd1htd Ke6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:date:subject:to:from; bh=TiK4vnMsdqbgsyhJob4CVVy583YeysvxfI7/BS54H3o=; b=c0GNdJ/IxNO6vt0GEeMV+ax2oFg79kXnI8D3aRTNwrYoQn4oZp7gdrlYdQzBxOSLw/ tzGQ23UmLnDVsJbY/gDUdCSz/uOPP9soXDqvcaEadvfqe7c7DvA9S6j/8EjOd5bNWHEn IZSvS5A7CeoN5a9Sx4yx75UZXNIUCATx7vZzOazVY2AdHEapq0fEQEzllqiOblkC3v/c AugSOTzbipUBwYc4Lcg2mE9Shh2j3a4ZncLou1mo10dsRPvziUM5HOdELL9D5LrV2kzW ggGX1UP4XEhA18mNB0RSc7By8008by95nM48EhFNWpNFynRb2OKUeV4d/66duzcM3t2b M19Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si8451046eje.336.2019.10.01.06.30.22; Tue, 01 Oct 2019 06:30:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388501AbfJAN3x (ORCPT + 99 others); Tue, 1 Oct 2019 09:29:53 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39466 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388414AbfJAN3x (ORCPT ); Tue, 1 Oct 2019 09:29:53 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x91DR9NW001313 for ; Tue, 1 Oct 2019 09:29:51 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2vc71q97b0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 01 Oct 2019 09:29:49 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Oct 2019 14:29:33 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 1 Oct 2019 14:29:31 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x91DTTG545088888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Oct 2019 13:29:29 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52C934C073; Tue, 1 Oct 2019 13:29:29 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4D734C075; Tue, 1 Oct 2019 13:29:28 +0000 (GMT) Received: from pomme.tls.ibm.com (unknown [9.101.4.33]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 1 Oct 2019 13:29:28 +0000 (GMT) From: Laurent Dufour To: sfr@linux.ibm.com, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/pseries: Remove confusing warning message. Date: Tue, 1 Oct 2019 15:29:28 +0200 X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19100113-0008-0000-0000-0000031CC5B7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19100113-0009-0000-0000-00004A3B701D Message-Id: <20191001132928.72555-1-ldufour@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-01_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010122 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the commit 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics"), a warning message is displayed when booting a guest on top of KVM: lpar: arch/powerpc/platforms/pseries/lpar.c pseries_lpar_read_hblkrm_characteristics Error calling get-system-parameter (0xfffffffd) This message is displayed because this hypervisor is not supporting the H_BLOCK_REMOVE hcall and thus is not exposing the corresponding feature. Reading the TLB Block Invalidate Characteristics should not be done if the feature is not exposed. Fixes: 1211ee61b4a8 ("powerpc/pseries: Read TLB Block Invalidate Characteristics") Reported-by: Stephen Rothwell Signed-off-by: Laurent Dufour --- arch/powerpc/platforms/pseries/lpar.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c index b53359258d99..f87a5c64e24d 100644 --- a/arch/powerpc/platforms/pseries/lpar.c +++ b/arch/powerpc/platforms/pseries/lpar.c @@ -1419,6 +1419,9 @@ void __init pseries_lpar_read_hblkrm_characteristics(void) unsigned char local_buffer[SPLPAR_TLB_BIC_MAXLENGTH]; int call_status, len, idx, bpsize; + if (!firmware_has_feature(FW_FEATURE_BLOCK_REMOVE)) + return; + spin_lock(&rtas_data_buf_lock); memset(rtas_data_buf, 0, RTAS_DATA_BUF_SIZE); call_status = rtas_call(rtas_token("ibm,get-system-parameter"), 3, 1, -- 2.23.0