Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 1 Oct 2019 15:30:55 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v1 4/4] usb: host: xhci-tegra: Switch to use %ptT
Message-ID: <20191001133055.GA3563296@ulmo>
References: <20190104193009.30907-1-andriy.shevchenko@linux.intel.com>
 <20190104193009.30907-4-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu"
Content-Disposition: inline
In-Reply-To: <20190104193009.30907-4-andriy.shevchenko@linux.intel.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--WIyZ46R2i8wDzkSu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 04, 2019 at 09:30:09PM +0200, Andy Shevchenko wrote:
> Use %ptT instead of open coded variant to print content of
> time64_t type in human readable format.
>=20
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/usb/host/xhci-tegra.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>=20
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index 938ff06c0349..ed3eea3876e2 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -820,7 +820,6 @@ static int tegra_xusb_load_firmware(struct tegra_xusb=
 *tegra)
>  	const struct firmware *fw;
>  	unsigned long timeout;
>  	time64_t timestamp;
> -	struct tm time;
>  	u64 address;
>  	u32 value;
>  	int err;
> @@ -925,11 +924,8 @@ static int tegra_xusb_load_firmware(struct tegra_xus=
b *tegra)
>  	}
> =20
>  	timestamp =3D le32_to_cpu(header->fwimg_created_time);
> -	time64_to_tm(timestamp, 0, &time);
> =20
> -	dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
> -		 time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
> -		 time.tm_hour, time.tm_min, time.tm_sec);
> +	dev_info(dev, "Firmware timestamp: %ptT UTC\n", &timestamp);

If I understand correctly, this will now print:

	Firmware timestamp: YYYY-mm-ddTHH:MM:SS UTC

whereas it earlier printed:

	Firmware timestamp: YYYY-mm-dd HH:MM:SS UTC

So the 'T' character is different now. Could we make this something
along the lines of:

	dev_info(dev, "Firmware timestamp: %ptTd %ptTt UTC\n", &timestamp,
		 &timestamp);

To keep the output identical? It's possible that there are some scripts
that parse the log to find out which firmware was loaded.

Thierry

--WIyZ46R2i8wDzkSu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl2TVQwACgkQ3SOs138+
s6FHsw/8C8TdckQdLtcvasjLL642TQY/rkVk+I9v1mPG28VZD8cEECNuIMM6nHRP
IMLX4zk6KcizU4UqKGsc6dtI0NwjrpEU8yXaZj98gBZxDy4xY6fSoreFV5AtbRgz
5VyS244I3weK88MhFbb5IDwF+GcNu7RxIohs8gpipCpUfSDsV4QsxQtWc/AS9G6P
p5o+BgPGPcPS4wkpWyBDyi0WBg5aw/p+AQ74SW1/phVmypVfyEiStTixzicrEAu3
v2W95xU+JH9UOc5RlIiyC/Ni72wCUGMz1uKyjpvOhh7ih8fOyGHpRfIssjko589c
ojJk4MfDTQA6ghRBShPU6LyeUTmnjR8SejdjtNZOXSNygWCGkhRbtN6tXcQzkd8D
NtTqmkXbl3PPDLwrFNp+5QFfBsftnyK/Pnsk0/G+Y6Mb0n1CuAneOUI6YueXDgGv
T4K59RylicPuTFc3RIB+eVcnfvYloDoLYJDekSPAy2LeDyRYFgrG84WsZn/4lWZC
GYaJbPZ3NCR9MxWSIzKvqXJCeDl/e/zziYDhIiqpAjBbWEZNaZOGol4lR6pT+IK9
gRxvqglWXsHhAZ3+mfw4f7TqEpDkDGa4Mr6mCckSXVAaxZ1QLSR2En2GO3Vp3+5P
iihHaXYEJBzqc0Lqn2iHexLj+gydqmov9WcwWirOlWQeWPftU5Q=
=5ex1
-----END PGP SIGNATURE-----

--WIyZ46R2i8wDzkSu--