Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8326394ybn; Tue, 1 Oct 2019 06:38:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqxY4d7t9JVM/vc++pAKQMuKiAngXurDlT28x2QzHpb/mkF4iXR5CiVYG8/CVvKLw+N5HwFf X-Received: by 2002:aa7:c657:: with SMTP id z23mr25672013edr.234.1569937123927; Tue, 01 Oct 2019 06:38:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569937123; cv=none; d=google.com; s=arc-20160816; b=QkGJln8FKZl6KQLg2KnBQQNutps3SXeDYa+27+0AHB+X778K21kt1fhnV/xjKg/YmN pSYIN9nvWa7bbD5hnqDcLnA340E1/2kWq6nq6n621tDtdCic3VBbHwP3QEOcGipxlvzJ xAFPi4mcmm//7o/6xSHTpGAM6HyeLJeqImlytN0z0c5dBLOpWga6Sv6pQGBQHuUBz+pY gUc/i8wMBB4JAwiQR+rsGMMWwdaLJcNPMX186wplaSolBR5VXB1/8YkTB82tAkxpQU3x ktA93h23zVQVnnZkMgOiEXwiasz+6gunzjEnqfmrC0h81EtzMrRKya5BVUkAOc05fVgp U6uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:to:from:date; bh=K0FQEE+XQpxg52Tc1gtF4m2ndrZUMMuL9im37HbLAGo=; b=weulcIU9Q3L33EFtXKBd0wt1xnvYpa48K7ZIxLHmw8VJnSkk3nmQp3hhadEk+xwlhf co+zGna1KwAXWN4VDsfDddY43M7q++fO3VbGQM5pxregKJLoH8TX6cj0kquhPqUWCjFV KzXe97cWTSdjhI6/eoWLsZPSkPMuHFEdnSux8+BiZuGrUjioIRWSumgu+k0RGSLf1bW3 SW7pobg3zrPKRoIJCgjSWy9QuO5sriu7m5z/PzKlXZyzq0M+BP9QDlbdFjMguRBWQAeB aqEltwfrv3pTL0DRT74q9x4yMIurZCruhZPauSQZ6SXVXY0300lYm7QFO7/8iKwRhfmq fjQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18si9109357edb.155.2019.10.01.06.38.17; Tue, 01 Oct 2019 06:38:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388595AbfJANho (ORCPT + 99 others); Tue, 1 Oct 2019 09:37:44 -0400 Received: from relay-b03.edpnet.be ([212.71.1.220]:50797 "EHLO relay-b03.edpnet.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388185AbfJANhn (ORCPT ); Tue, 1 Oct 2019 09:37:43 -0400 X-ASG-Debug-ID: 1569937057-0a88186e2343f92e0001-xx1T2L Received: from zotac.vandijck-laurijssen.be (77.109.119.18.adsl.dyn.edpnet.net [77.109.119.18]) by relay-b03.edpnet.be with ESMTP id lhxlEiytuwtOONF6; Tue, 01 Oct 2019 15:37:37 +0200 (CEST) X-Barracuda-Envelope-From: dev.kurt@vandijck-laurijssen.be X-Barracuda-Effective-Source-IP: 77.109.119.18.adsl.dyn.edpnet.net[77.109.119.18] X-Barracuda-Apparent-Source-IP: 77.109.119.18 Received: from x1.vandijck-laurijssen.be (74.250-240-81.adsl-static.isp.belgacom.be [81.240.250.74]) by zotac.vandijck-laurijssen.be (Postfix) with ESMTPSA id D7800A1ED53; Tue, 1 Oct 2019 15:37:36 +0200 (CEST) Date: Tue, 1 Oct 2019 15:37:35 +0200 From: Kurt Van Dijck To: Jeroen Hofstee , "linux-can@vger.kernel.org" , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH 2/2] can: C_CAN: add bus recovery events Message-ID: <20191001133735.GA32369@x1.vandijck-laurijssen.be> X-ASG-Orig-Subj: Re: [PATCH 2/2] can: C_CAN: add bus recovery events Mail-Followup-To: Jeroen Hofstee , "linux-can@vger.kernel.org" , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , "open list:NETWORKING DRIVERS" , open list References: <20190926085005.24805-1-jhofstee@victronenergy.com> <20190926085005.24805-3-jhofstee@victronenergy.com> <20191001074057.GA28813@x1.vandijck-laurijssen.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191001074057.GA28813@x1.vandijck-laurijssen.be> User-Agent: Mutt/1.5.22 (2013-10-16) X-Barracuda-Connect: 77.109.119.18.adsl.dyn.edpnet.net[77.109.119.18] X-Barracuda-Start-Time: 1569937057 X-Barracuda-URL: https://212.71.1.220:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at edpnet.be X-Barracuda-Scan-Msg-Size: 685 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: SPAM GLOBAL 0.9980 1.0000 4.3191 X-Barracuda-Spam-Score: 4.32 X-Barracuda-Spam-Status: No, SCORE=4.32 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=7.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.77000 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On di, 01 okt 2019 09:40:57 +0200, Kurt Van Dijck wrote: > On do, 26 sep 2019 08:50:51 +0000, Jeroen Hofstee wrote: > > While the state is update when the error counters increase and decrease, > > there is no event when the bus recovers and the error counters decrease > > again. So add that event as well. > > > > Change the state going downward to be ERROR_PASSIVE -> ERROR_WARNING -> > > ERROR_ACTIVE instead of directly to ERROR_ACTIVE again. > > This looks like a proper thing to do > Acked-by: Kurt Van Dijck Thanks for this, now I see when the bus is normal again. Tested-by: Kurt Van Dijck