Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8329117ybn; Tue, 1 Oct 2019 06:40:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyz5/R2E+rthYMODyTcMzxjnjFFP/MBcjf3CyYccHl2KSwLfdz9iVTVUvtXmIlDUc6mEjKE X-Received: by 2002:a17:906:1c5b:: with SMTP id l27mr24386197ejg.27.1569937258861; Tue, 01 Oct 2019 06:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569937258; cv=none; d=google.com; s=arc-20160816; b=THgU9IaP1m7GhmPRVFYZd6PSWuDarYtmQPMpTHPMyAdz8/GWiul3pcELoi14q8SOqY +sE8y0XaCi34pdTnTnq+I/rR1v47LmkrG8dY9VMiXEojnY0CnMgPL/WCWWPJCsxo5otb uAduhRSFBSuV+4Hceak0Nb2KnVSC3yCMBuGvAAWLS0YBi1kJt5+jf5ewq+HtQV7fhNmN v9It46sK01UrR51coK1kiAWQOgPzA+Dc2ONbnSHz+W4ZqwASnIaRnMYua78kuzSC0oKx /0mGxwP3q1KALEI+SNPlGMATQCTlAG1Rp6hyy0BTsUfCDRfOJk1h9CMOngJE+mqH4jqX Bo5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=ngP3YGTp9qkZex5ChUnMhHznx0S1fGKeH3i9Oe6/UPY=; b=PZCPbj7l99exxAMEhNokU5xBaoNJORBrHkf00Wh3DouOpoDMc1Ckos+pgxLEi/tdY3 npLe1p60JZuIDJu6akaChCGM8JGVrhzYP25GPEZmbkJPRhbOoyopCcIG1SdFpO3Y1q+N +OV8jBed0FudIe+BusK0zCf8sUjKQhbYlA9GfxmSPDdcuYq3hJ7zYoYHTwzvof4UhU1Q n9sz4disMxMTMuRAR/lJBhKgSXfxrWaLSkWf+YEeCvaRJmgc2FGW4c6XAYfSixdFEsqi qS+kMzyl3pLqBCytNbjqYdu+BR+CWjXGR0L4f79n4k5Hx8wWCufERXM0pk/+8HnBmnpJ ymXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9si8488667eju.298.2019.10.01.06.40.34; Tue, 01 Oct 2019 06:40:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388637AbfJANkC (ORCPT + 99 others); Tue, 1 Oct 2019 09:40:02 -0400 Received: from relay-b02.edpnet.be ([212.71.1.222]:34887 "EHLO relay-b02.edpnet.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388415AbfJANkB (ORCPT ); Tue, 1 Oct 2019 09:40:01 -0400 X-ASG-Debug-ID: 1569937198-0a7b8d53c1e88220001-xx1T2L Received: from zotac.vandijck-laurijssen.be (77.109.119.18.adsl.dyn.edpnet.net [77.109.119.18]) by relay-b02.edpnet.be with ESMTP id IODp9MwrRJmoWr37; Tue, 01 Oct 2019 15:39:58 +0200 (CEST) X-Barracuda-Envelope-From: dev.kurt@vandijck-laurijssen.be X-Barracuda-Effective-Source-IP: 77.109.119.18.adsl.dyn.edpnet.net[77.109.119.18] X-Barracuda-Apparent-Source-IP: 77.109.119.18 Received: from x1.vandijck-laurijssen.be (74.250-240-81.adsl-static.isp.belgacom.be [81.240.250.74]) by zotac.vandijck-laurijssen.be (Postfix) with ESMTPSA id 555E6A1ED6B; Tue, 1 Oct 2019 15:39:57 +0200 (CEST) Date: Tue, 1 Oct 2019 15:39:56 +0200 From: Kurt Van Dijck To: Jeroen Hofstee Cc: "linux-can@vger.kernel.org" , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH 1/2] can: D_CAN: perform a sofware reset on open Message-ID: <20191001133956.GB32369@x1.vandijck-laurijssen.be> X-ASG-Orig-Subj: Re: [PATCH 1/2] can: D_CAN: perform a sofware reset on open Mail-Followup-To: Jeroen Hofstee , "linux-can@vger.kernel.org" , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , "open list:NETWORKING DRIVERS" , open list References: <20190926085005.24805-1-jhofstee@victronenergy.com> <20190926085005.24805-2-jhofstee@victronenergy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190926085005.24805-2-jhofstee@victronenergy.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Barracuda-Connect: 77.109.119.18.adsl.dyn.edpnet.net[77.109.119.18] X-Barracuda-Start-Time: 1569937198 X-Barracuda-URL: https://212.71.1.222:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at edpnet.be X-Barracuda-Scan-Msg-Size: 627 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: SPAM GLOBAL 0.9475 1.0000 3.7440 X-Barracuda-Spam-Score: 4.74 X-Barracuda-Spam-Status: No, SCORE=4.74 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=7.0 tests=BSF_SC2_SA016_OB X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.77000 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 1.00 BSF_SC2_SA016_OB Custom Rule SA016_OB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On do, 26 sep 2019 08:50:44 +0000, Jeroen Hofstee wrote: > When the C_CAN interface is closed it is put in power down mode, but > does not reset the error counters / state. So reset the D_CAN on open, > so the reported state and the actual state match. > > According to [1], the C_CAN module doesn't have the software reset. > > [1] http://www.bosch-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf > > Signed-off-by: Jeroen Hofstee I observed no problems after applying the patch. Tested-by: Kurt Van Dijck