Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 1 Oct 2019 10:45:55 -0300
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Noralf =?utf-8?Q?Tr=C3=B8nnes?= <noralf@tronnes.org>
Cc:     dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch,
        sam@ravnborg.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
Message-ID: <20191001134555.GB22532@ziepe.ca>
References: <20190725105132.22545-2-noralf@tronnes.org>
 <20191001123636.GA8351@ziepe.ca>
 <1fffe7b1-a738-a9e3-ea5f-9d696cb98650@tronnes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1fffe7b1-a738-a9e3-ea5f-9d696cb98650@tronnes.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
> 
> 
> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> > On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> >> This makes the tiny drivers visible by default without having to enable a
> >> knob.
> >>
> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
> >>  drivers/gpu/drm/Makefile        |  2 +-
> >>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
> >>  2 files changed, 22 insertions(+), 17 deletions(-)
> > 
> > Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> > breaks kconfig stuff in v5.4-rc by creating circular
> > dependencies. Could someone send a -rc patch to fix this please?
> > 
> > THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> > ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
> > ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> > ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
> > ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> > ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> > ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> > ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
> > ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> > ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> > ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> > ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> > ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
> > ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> > 
> 
> Would this commit fix this by any chance:
> 
> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a

Yes, thank you, can someone send this to -rc to unbreak 5.4?

Jason