Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8392953ybn; Tue, 1 Oct 2019 07:31:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQb3d/RPWOja5UuolatUjY4uDAFo+IuSm7l1Cae62tPCRDWXMF0+wjDEi5RGd//3GxLd+4 X-Received: by 2002:a05:6402:1202:: with SMTP id c2mr25007397edw.190.1569940294034; Tue, 01 Oct 2019 07:31:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569940294; cv=none; d=google.com; s=arc-20160816; b=vVUSBTiB9zZgAUsqlzSFUSIrbJNXpq/RocrP+U0ePvGhU70vkxuCNpV3jOGe25PPBu S/zGPcymVEcCPBEegW9bJ6+xFGV0fpUGv8JYcU8U5id3VRKxDp+V2UQBfOKHPKaaSk/y NbXBepZVc96NAK28NNR18ba41wV2F2Fh96+pX4FX9xdMsKqWZyyDPu9hjNKSC2LZQGPW lO1JpO/OxNjwByJJB0ax1LskAEqYsLGi9HUKQIvwNDTkYneop/YgsX4QNRqZ4RBMbV/u QA5w8XF8/btdidrsNXNqXPsgX1jDMfV4XXvbomCynpONs9+kuYUDvt7BpH0YgDPd8M4X d9HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tP7RCvEbzIaJlmJdGGsTmP87zeFxDfN1vsHcqjIyPqk=; b=wbkvwkBSVsHnu5102XhTuq4LCAteRqastFxc9oHn0HPN6P+Eun92SPOclEPE/5YnDh rE+5LSVl720c5eNBIbccmR1Q4eWxrZucaiulSx6QbevBqzJ457g2BMtJWxUpLXgD+YJz WD6KKFe41mMXGse0Id7xxKy0k6LbQEwEwoSuuSBXHCQKiONpE3kAPnMgEG8MIAD429Pf TRinR0ZxFnWjrIXDoDBT/4pprTzA34+m/Z4FqZcc++FL3NuweFLfN5wtwAEWnevX61rX NVz1Q3z7s7vF2nZPtEU8lbfEqIZ8URfPu1qOK8b1LvrTUDHNsm72fWsltfRnKK7lRFul WZBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lZvD4CnX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y3si9892939ede.38.2019.10.01.07.31.09; Tue, 01 Oct 2019 07:31:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lZvD4CnX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389018AbfJAOah (ORCPT + 99 others); Tue, 1 Oct 2019 10:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:39420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388891AbfJAOah (ORCPT ); Tue, 1 Oct 2019 10:30:37 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 247152086A; Tue, 1 Oct 2019 14:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569940236; bh=tP7RCvEbzIaJlmJdGGsTmP87zeFxDfN1vsHcqjIyPqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lZvD4CnX8ONT4otE5cDFdiaurTDkXerUxA0fiPduF44DCg0bvnCsjNkGU0XT72XTo /EXwMZyWn45/h+cQ2YPzvsd0SCbbCacA60bopujwzjcpfIa3CyDGyiakSyL1Jzo3CK QG7ozMk8Ux9eVQx6k3v4uxJvXUHc/z3Y4kdVFejc= Date: Tue, 1 Oct 2019 10:30:35 -0400 From: Sasha Levin To: Sakari Ailus Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.3 084/203] media: omap3isp: Don't set streaming state on random subdevs Message-ID: <20191001143035.GV8171@sasha-vm> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-84-sashal@kernel.org> <20190923071942.GJ5525@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190923071942.GJ5525@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 10:19:42AM +0300, Sakari Ailus wrote: >Hi Sasha, > >On Sun, Sep 22, 2019 at 02:41:50PM -0400, Sasha Levin wrote: >> From: Sakari Ailus >> >> [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] >> >> The streaming state should be set to the first upstream sub-device only, >> not everywhere, for a sub-device driver itself knows how to best control >> the streaming state of its own upstream sub-devices. >> >> Signed-off-by: Sakari Ailus >> Reviewed-by: Laurent Pinchart >> Signed-off-by: Mauro Carvalho Chehab >> Signed-off-by: Sasha Levin > >I don't disagree with this going to the stable trees as well, but in that >case it *must* be accompanied by commit e9eb103f0277 ("media: omap3isp: Set >device on omap3isp subdevs") or the driver will mostly cease to work. > >Could you pick that up as well? Sure, I've queued it as well, thank you. -- Thanks, Sasha