Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 1 Oct 2019 10:45:13 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jiaxin Yu <jiaxin.yu@mediatek.com>
Subject: Re: [PATCH AUTOSEL 5.3 087/203] ASoC: mediatek: mt6358: add delay
 after dmic clock on
Message-ID: <20191001144513.GW8171@sasha-vm>
References: <20190922184350.30563-1-sashal@kernel.org>
 <20190922184350.30563-87-sashal@kernel.org>
 <20190923182159.GV2036@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20190923182159.GV2036@sirena.org.uk>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 23, 2019 at 11:21:59AM -0700, Mark Brown wrote:
>On Sun, Sep 22, 2019 at 02:41:53PM -0400, Sasha Levin wrote:
>> From: Jiaxin Yu <jiaxin.yu@mediatek.com>
>>
>> [ Upstream commit ccb1fa21ef58a2ac15519bb878470762e967e8b3 ]
>>
>> Most dmics produce a high level when they receive clock. The difference
>> between power-on and memory record time is about 10ms, but the dmic
>> needs 50ms to output normal data.
>>
>> This commit add 100ms delay after SoC output clock so that we can cut
>> off the pop noise at the beginning.
>
>This might mess up a production system, please don't backport it.
>In general delays to eliminate pops and clicks that are part of
>the PCM statup path (as opposed to DAPM) are not safe to
>backport.

Okay, I'll drop it, thanks.

--
Thanks,
Sasha