Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8422175ybn; Tue, 1 Oct 2019 07:55:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuqHp+PEC8p5uhSFCKm6qLzZUPVOxeqxKqpzg4AFEyAe0TymOIfGT4C58om1Lhl6eoI5mt X-Received: by 2002:a17:907:2118:: with SMTP id qn24mr24265581ejb.81.1569941745424; Tue, 01 Oct 2019 07:55:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569941745; cv=none; d=google.com; s=arc-20160816; b=BtOVvF9tm8AupBynsk3a0Fyn/Z26Rq/RY4imE+VKLl7Ci6WXqLOW+UGVu0POIN6cAd S2cBiw41Gj9alSkOK64KG4onE6gzdIlxLNo6e+nhYK94nQQotTdLgCNWHRPzJcaDWaTM PDTJEjyc6Hu9xofo0uL0cMqMt0nF0qCFmHtHGDfgerUjNdcoGYrcfL22rSBSRTtOkgZU QS3IVptJnAn6SRzWb+I7XHLwO088fOp9kIT7xo+ylTC3hT1Pxra/9TN43sdBFc+Prefp 8IHCJGuUBUqY6gBLS2gqJB5Ty65pfqLQPeOCe7Dnl3amOU7HjOul7V6ohryHbHIgPo2T xGJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/sgBuHzDkyP86LCDuWDV/NGAWdqVkiJJL/3pEIc5/TI=; b=oi/si/20yA/Oqm9BTbO9GfuESjKePL0scYoX+60jQ68uhT6jTtJ6fiwIfPtQxX9na0 dER1nooXBIn8pfqVCAt/baXoWv4QWdtpwCFBErFwIWOujlrtYm6/lJ67esIXPKbZx9uX Ra3WG06qMzHBXOJH+pKCbvkvOiYq7ix/enMyZFetp0aBvtmWcvKzZRT37VHTyLL3DGBf 88oTYsMNNLkawO69amVHtdIfQErCqQ4sAdkOw7LEYZdlw7pQ0Qr2clM8z/fsdDYJBn3p 03KAOCXhysjxUf5x0teA0kftCGAkwdS/yhXBCRLKqgTECPVKElH0lPOX0WYS+xZEMvW+ Bzwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oiJasVlV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y3si9946128ede.38.2019.10.01.07.55.20; Tue, 01 Oct 2019 07:55:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oiJasVlV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389145AbfJAOx7 (ORCPT + 99 others); Tue, 1 Oct 2019 10:53:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727143AbfJAOx6 (ORCPT ); Tue, 1 Oct 2019 10:53:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81C1220815; Tue, 1 Oct 2019 14:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569941637; bh=ZZ63NgRB4la/JntiVLUk4sSc2uMP4usvtqmHwu3XxTs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oiJasVlV/zy+HQBB3apaVUeS88GLzmWZf3sELqH6JOyNmq4K7MjVnegmzgtjg/VJA S4oyDx7A4/DF7rZt9NET7tydhgIkY0UlbdfKqHHL8nkFrL8izKLBWf3MKvMtpgVqcX yO2oZq61V2mJrj8OmQqiGAZE7tXg9fIaa8964USI= Date: Tue, 1 Oct 2019 16:53:54 +0200 From: Greg Kroah-Hartman To: Mika Westerberg Cc: linux-usb@vger.kernel.org, Andreas Noever , Michael Jamet , Yehezkel Bernat , Rajmohan Mani , Nicholas Johnson , Lukas Wunner , Alan Stern , Mario.Limonciello@dell.com, Anthony Wong , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 17/22] thunderbolt: Add initial support for USB4 Message-ID: <20191001145354.GA3366714@kroah.com> References: <20191001113830.13028-1-mika.westerberg@linux.intel.com> <20191001113830.13028-18-mika.westerberg@linux.intel.com> <20191001124748.GH2954373@kroah.com> <20191001130905.GO2714@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191001130905.GO2714@lahna.fi.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 04:09:05PM +0300, Mika Westerberg wrote: > On Tue, Oct 01, 2019 at 02:47:48PM +0200, Greg Kroah-Hartman wrote: > > > - Thunderbolt Controller driver. This driver is required if you > > > - want to hotplug Thunderbolt devices on Apple hardware or on PCs > > > - with Intel Falcon Ridge or newer. > > > + USB4 (Thunderbolt) driver. USB4 is the public spec based on > > > + Thunderbolt 3 protocol. This driver is required if you want to > > > + hotplug Thunderbolt and USB4 compliant devices on Apple > > > + hardware or on PCs with Intel Falcon Ridge or newer. > > > > Wait, did "old" thunderbolt just get re-branded as USB4? > > Not but the driver started supporting USB4 as well :) > > USB4 is pretty much public spec of Thunderbolt 3 but with some > differences in register layouts (this is because Thunderbolt uses some > vendor specific capabilities which are now moved to more "standard" > places). Ok, then we need to rename the Kconfig option as well, otherwise no one will "know" that this changed, so they will not be prompted for it. > > Because if I have an "old" laptop that needs Thunderbolt support, how am > > I going to know it is now called USB4 instead? > > Well the Kconfig option tries to have both names there: > > tristate "USB4 (Thunderbolt) support" > > and then > > USB4 (Thunderbolt) driver. USB4 is the public spec based on > Thunderbolt 3 protocol. This driver is required if you want to hotplug > Thunderbolt and USB4 compliant devices on Apple hardware or on PCs > with Intel Falcon Ridge or newer. > > and the Kconfig option is still CONFIG_THUNDERBOLT. I know this is > confusing but I don't have better ideas how we can advertise both. I > borrowed this "format" from firewire. CONFIG_USB4 instead? > > Shouldn't there just be a new USB4 option that only enables/builds the > > USB4 stuff if selected? Why would I want all of this additional code on > > my old system if it's not going to do anything at all? > > USB4 devices are backward compatible with Thunderbolt 3 so you should be > able to plug in USB4 device to your old Thunderbolt 3 laptop for > example. It goes the other way as well. Some things are optional but for > example USB4 hubs must support also Thunderbolt 3. > > Does that clarify? Yes, it does, looks like marketing just renamed an old functioning system into a "brand new one!" :) thanks, greg k-h