Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8475807ybn; Tue, 1 Oct 2019 08:37:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBLvewIZfn9gt+OAi5QHqBzwGWVS9QewTqUoBCsdeNgB9ivicyTM9uOYIBIjSk699jE66P X-Received: by 2002:aa7:dc4b:: with SMTP id g11mr26662250edu.70.1569944258313; Tue, 01 Oct 2019 08:37:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569944258; cv=none; d=google.com; s=arc-20160816; b=QnC8BmivB8Kg23HDqD0CXh6ugy6SOMtrOhl/VEqnUXLvQaW4e3FjRQiQYBYwkI+q8W pR8vHnzL+gMGxB+ahe4KY5vJRf+E5nyJzwOlLXhUoWkj8LIutakofQj8hM77kMypN4oj RDy25Gf9K6hdqiyv5BZ/lhF7cTVNDGaQL0g3zsqa8fCUAVFibORNS1UZKJ4mBpjF991e ZgYXtXWbBmJGe2UFN8Qsmiip1LyDJdaT4fxvXkDFpAWKbiV29HJhoeOSgE1tzRQHU4De 5+kLhPHJolr8pGet3g5e6MMkXPKXf94Ge7pWRTQ5ePY7KXoZUQv9NyeQBM/gKUOW0ZEQ 977A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:from:to:subject:references:cc :dkim-signature; bh=9HXEykuWNUVAsJUWBSQTDK1o1l6WAA2Mg1kowcwpGZ4=; b=EL/UI7SWUTATBhQoGUuiph+MFlLYSdIrZoNOznKxu/kbMgWAaJD4UhoJ8GbYWCaInl g1bMh2FDHkfh7QRBMMFm6j82wjOSBFj4K+cQ8IX5vceazqe2LIkAfdXNyNG3er1EUxrS heQ7LDlAJduvzVpNxzHVKzeqXqDWZKEhlqr/Q8N9k1LGheWbEI/5zLgecmDJkqYXDRXG wFz60DX4JU/4T3gbnrJvD0fLujk2ldE67WcszLgmzmI+6KckBuNlk4Rip1phaCxyzNst ayjKugblBM/wtfE3ahG+Byf5lWdjWzSiB673RorfR3vkF5DYERhLu4KHv4fB2puy+Q2z nvxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=ezKp9xMq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i17si8779782ejc.233.2019.10.01.08.37.12; Tue, 01 Oct 2019 08:37:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=ezKp9xMq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389284AbfJAPeX (ORCPT + 99 others); Tue, 1 Oct 2019 11:34:23 -0400 Received: from mout.web.de ([212.227.17.11]:53777 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727236AbfJAPeW (ORCPT ); Tue, 1 Oct 2019 11:34:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1569944030; bh=9HXEykuWNUVAsJUWBSQTDK1o1l6WAA2Mg1kowcwpGZ4=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=ezKp9xMqqbDPet/e4W/1bc2kZi5UMGrAVXHo7fueXfXvGoKTPNy7ZJ4F21KW8DRxe 5OaGKPi6eW7duMb1rJlBKZq3B45tmUko+a4QTS9B7obOLFnHQ/Sa3gbhLEIx8Yhpev 4jDEG0L8GAStAzPsV34z101UzTX9ObUdjOz5e6ic= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.188.160]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LgpVS-1hlATb4A2o-00oFtv; Tue, 01 Oct 2019 17:33:50 +0200 Cc: linux-kernel@vger.kernel.org, Gilles Muller , Greg Kroah-Hartman , Jessica Yu , Martijn Coenen , Masahiro Yamada , Michal Marek , Nicolas Palix References: <20191001125742.GD90796@google.com> Subject: Re: [Cocci] [RFC] scripts: Fix coccicheck failed To: Matthias Maennich , Yue Haibing , Coccinelle , kernel-janitors@vger.kernel.org From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <15b52ec6-1cb4-f419-351a-07241cdb8674@web.de> Date: Tue, 1 Oct 2019 17:33:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191001125742.GD90796@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:GepFRLFllb+Ct4JtITS1wHh/sRQuKbLTrXNKcJYaZcueL8tbEIG Lr5IeATdKtkKoq3p1XgjvTpibMaGd9HiLQkVWhhT1Dn8LLWdklxCieTXRdVfj5iwp4Gxsyt dT65bIRyQzun2V4jMRxAvGdQgJLX8AK9t9xufoyePH35JMkZbSAV1TJ5/KOdLLoPr+velMu 4dX3ZYvRLtkmLEp8HcQuw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tRN22yKu0x4=:aV6vMeHVwg7gL8JCvjUZiR qehG5U838fq3BqaFyJqXKAPR2Ad5oPlKiuMQIwQNQwt4587votAQ1H6ctsOzfAmWDyyj/g6Bt 7lGWApF9ycNfvoWrrMUMlTZOE1PG2Z4dyUCI9c7JtZ7P2BRdeyMacXzndssC60icxn28cmAYg Ok0QRz6SmhK1ca5HQlrY1EVrLan5G8PnwtkpZFnrTCJclve4V74kVVAeHm5Rp6t3fYQxsVtlN +5S54sQm13u8o9KR3YfbDS1iCwkG6LnxazF8ayytZmWpFu9A09J1Q43r6hAvxs9d8aLPgcVbC hkiPg7DAOOWotlRjwG43qi8vhsz3VObZSg4nu5kLQjsebWlvXYFEVPztp/wyVHnP9iITwzXWm FmG4NT6MTivZtosVv94HessO9lJuUhAMHJ8eUn6UNTgBQDwDkg7K5KooUAnElpPCCdmQYcGc7 Vj4qiuj54m1Pj+uwT23i4UX//T0u2fISiJBi3pK9L2xpaLQmTBoFj/HN0m79NYPfIApw44ZUD TxbTm9odEGn5BlTBwDOnObHTPFeAkATRNdlgNLAcqwFTgsB8v5v+z8shgEXeXstLiA3luU1o3 2ouJ5JxRrd2JHYuh2n8wfRli1+fVX0/Sawqv5hh/sZ0FxaBOlDg71BYN7YWHWuWbVib7IQaUx 5u1hvFwx3cU4AGRyMhNKLRUSFZe39e/bD854yb4EoY3Ulqj9wwLqsEhDOQEUhooFzmllkbR8+ VOOCjq8tWL5J1Nch5WPidjwPXyfhE976BC0I8fk4HPevg2gxk6U7E7sFqI3oV3Out7tVyJnrj 3y0myNl5L6G/le5lmVb19QBTUf9osMVQGV2TSrJ+RCZ9KB94MuWCOKvxyRme7xLhUrP07EM7T HxWN5+MGG8+BXU0K0vi0q423p1gfOCewtsSlLNX/fxTVeFkq7RHbwGLMC6ZghxtmbuTtyMAjO 926h2V+QxJc1qZwLDAzA3fbDMYEJBOJp2tS0VRkIgl5OmrJ0nEc5dLt5pQbDIV15rUxCOgQ5h IoBwJGewG5i/lOSRC4qbEle288uGdcmYOG53mKK0u0rvSbLdg4IXyV4Dkbq77guO4FYt3kouT qLHZE4fG163LfK5/UjzD5Cp1FRcaGUaC42UkwEt2VPFuRNUGzE+2rQn8LMarwTjvaMVAKgyF0 TtcP/iO+w+uaAJoqmcqhjUdRYIhGN12usBoWhTk9BqYUDjLx/0x2/bC5OnRg89/PqTrQnynId k1RW9npXLZhIpOqdx1SyPWb+FrYDIJ1mcuyfQcd43BAZ23S3TKJjglfG9+mo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >+virtual report > >+ > > @has_ns_import@ > > declarer name MODULE_IMPORT_NS; > > identifier virtual.ns; > > > >Adding virtual report make the coccicheck go ahead smoothly. Such an adjustment might be an interesting solution. > Thanks for reporting and following up with this issue. I certainly did > not expect all scripts in scripts/coccinelle to be automatically called > by coccicheck Did you (or any other contributor) test the collaboration of the added small SmPL file with the known call interface? > and I still think scripts/coccinelle is the right location > for add_namespace.cocci. I got additional software development ideas around this view in the meantime. Would you like to take any other collateral evolution better into account? Regards, Markus