Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8561312ybn; Tue, 1 Oct 2019 09:50:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFF/0w5j8uwfv0877vwB21qbWS+YTRWarZZSaULEP+Nio7nf/Io5iN5ogOpbe2UKpi7uKB X-Received: by 2002:aa7:c4d0:: with SMTP id p16mr26752474edr.266.1569948611655; Tue, 01 Oct 2019 09:50:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569948611; cv=none; d=google.com; s=arc-20160816; b=0iiirmdvCk86j0zLvkEw6NYodq+2Ey1Ykn/rjYcdsFQBvr37W/WK3trM0p4PEGQh8B Nhh9CyndKx6DJ5sHwaQol/L2j56tZ/XAQe9vAV5x+O66hGu0/h/GpNaHJOOZK5JlpV5V e5v0jpWn3u/te/uw3lnLlsFOAZOMoPIIGungVJGAleU+Bpacn6YYGO/7qAtkBi75P9a5 fcAb1aQf/x20pj3Kno+4F1812zSnf54ElH+5I55NWB+o7aO5fcLrvFQznRtxaBd/V1rR 73dAgalaL/2Nm+jqzN5ZaBEkr2zS0e8JCi4tUpF5nr8HfGCFVihX7gK48Wm8HjSmCngt IB6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=YmxH1eQFuXO1nlfHBlpkvRmFIbSG4PIvSjM5JX5mSe8=; b=GyqLbAeNDQorCN+J0h7vWQ2wOJJhnk6Jpy+XtgChB6+3QI8gAAJ2irhZVWUEVeidfQ 7ydDsFEPMw4wLzP2Z/u1xozEeJikh+dpGnPZiLCbxDffflMcpfBG3vg6rWTUgRIbNeyy CyKzn9M/glXJSS9ZHZUjG3aiehdxyo0yHRXTfcgu93f6fhHpHkd/adAlXYsVsDeYbrce /vcuiPU+/ScMjfWL9QAx0p4guzBwCv3EWX6dqeQE1NADlJLIKZ+QZqWcTJs7V0OLpsFR cYKz6CfWZGxJZL0dQSAhGQkLCpnBc9VAQpgfa2NZiv9VfIfwJgEJZFHiUXFmL/0Jzkp+ WaOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si9106075ejb.145.2019.10.01.09.49.34; Tue, 01 Oct 2019 09:50:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733084AbfJAQDY (ORCPT + 99 others); Tue, 1 Oct 2019 12:03:24 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49020 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbfJAQDY (ORCPT ); Tue, 1 Oct 2019 12:03:24 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A1C82154A804B; Tue, 1 Oct 2019 09:03:23 -0700 (PDT) Date: Tue, 01 Oct 2019 09:03:20 -0700 (PDT) Message-Id: <20191001.090320.1192378852987776883.davem@davemloft.net> To: o.rempel@pengutronix.de Cc: jcliburn@gmail.com, chris.snook@gmail.com, andrew@lunn.ch, kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: ag71xx: fix mdio subnode support From: David Miller In-Reply-To: <20191001064147.23633-1-o.rempel@pengutronix.de> References: <20191001064147.23633-1-o.rempel@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 09:03:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oleksij Rempel Date: Tue, 1 Oct 2019 08:41:47 +0200 > @@ -571,7 +571,9 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) > msleep(200); > } > > - err = of_mdiobus_register(mii_bus, np); > + mnp = of_get_child_by_name(np, "mdio"); > + err = of_mdiobus_register(mii_bus, mnp); of_get_child_by_name() can fail, so error checking is necessary before you pass mnp into of_mdiobus_register().