Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8562528ybn; Tue, 1 Oct 2019 09:51:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOC1VlqKi9UECXaMKgn/nDDSiMpjjBrafs+GJP7tJ2l+2eq8+HoWZIOqCvsbVkUIofIV+u X-Received: by 2002:a17:906:a40d:: with SMTP id l13mr24091195ejz.237.1569948680676; Tue, 01 Oct 2019 09:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569948680; cv=none; d=google.com; s=arc-20160816; b=WdMxYplC9BaQgTT92ksXpSyzoGkKl7cmpwZxz/T7GouaxvPLa35k1EMSOQ9nqigZwQ Rfd6qoYCwNyHU+cvXZWT4CTh4IX06koYj9sT9ZxvkC1sbZvml6lcKV5WSGcSWjAMi2zG tS4bK6hZ0nKbMwBUtTMgZn9jRslr2ws2yPQQZ0LEoDZlzIibiqVd0zjSDTLOIBSx/sEx WqwqDS5rDgQCovCd30D3jzc5cLkMxvcvymALYGziBoyu8u4Wh4F8Vw+x8LHfT0kR2Auk r/tepG2cRki30p4iwGkilNrAtBemVW9VYqsXi2HBFRD11X9sk0mUqG32hSxzbkv/qzAd GsCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=zGjQR/sTKc3smldtiGbvkknjnXT+JplA/pSqSqfQKlI=; b=nuIbWdjJ8CmATufKIZFj+r0xxo8aSFqBZt5X/dAKVPg+Db5CaAEbGzT5uqr9x1MUtf kQMTr1i1WqESafQSWzjpYbUWM/sA4Way8aX/Q2ummxb8IiktQu0DFu+Y1QqlqXxIj2Nd BGkh81EOQMf7GJitAFU92LsIlwBpAVneRdCU6FEHZ1EV0LyAmd6MOJtX189UPDlqHYwK VF+g2XEQFigjLcjvZy5KBuXoyiNvO8crgSzjRM+es8NvzqvBBU4PDG5KZWqWOHHTFAhl ltxQiB144KVUypq3g/B/eL+FhusWAbgbjtTMEMwI0d+9fIc1ROU6eUUmBGgblbiOH66F AviQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=G+DasL0i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 26si10025460ejl.292.2019.10.01.09.50.56; Tue, 01 Oct 2019 09:51:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=G+DasL0i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389887AbfJAQVZ (ORCPT + 99 others); Tue, 1 Oct 2019 12:21:25 -0400 Received: from mail-pf1-f202.google.com ([209.85.210.202]:33466 "EHLO mail-pf1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389775AbfJAQVZ (ORCPT ); Tue, 1 Oct 2019 12:21:25 -0400 Received: by mail-pf1-f202.google.com with SMTP id z4so10639761pfn.0 for ; Tue, 01 Oct 2019 09:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=zGjQR/sTKc3smldtiGbvkknjnXT+JplA/pSqSqfQKlI=; b=G+DasL0iJZ5kBOTu/zg5lhBzEt6jZOfAi1wnx0r7cOAZ7BldGdYXaJI63ngD6HwE+O td2ExZht8/oykOJ6vj3MIg3yGym9/ezKCc3UmfSjNgdhuBL1BlabvNzMYb2E3ZmK4lmR xKQSP9pNUpOfgoU/c44mv2JlOPpsdNSPsp6QouWh475Br8GI5iE0CIHgwsannd+OKyWt kctUWW68POaqfmJytgwPWY5G+l1LIwfEbaTs2bpLH0Umzhe8ZJmbA42UbPso+f2qtHUY ulHHgYlPaHHs5q5C7uw6TN6jFgZV8vOqg7CfY4xxzi79Ymw1jMuYTQHemWXww+T+xqMs yHPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=zGjQR/sTKc3smldtiGbvkknjnXT+JplA/pSqSqfQKlI=; b=F2ao1a3KlCiAUyWxH0zAZtz1W5wGKGsUV0Kf2roIudbE/7QziIFVPNa/eFZ2qyvLD3 Ft39+PtOc71LbQT0hXfuLXF5JxhlAm6l31dybhVyUriwd7Myi7SvmJkOWzCDDZKxEeU3 GQ21rxpoSMclW9PJZEComU0xCC+uJaYf6y+5oI0+PUsZiG1rsCPcXaZZFB9keqDlDvY1 dSOUoC10q/oiQWfDoER5BliZtkEinn7OjTdDSJnEBg2AUZrHnFYY5c1bIkM4CpLKvFVT NHWNsyiRehEQbhNQUz2IOq4nNqua7qdVdTWbvHcSbclsp8dg71EJbfr2h2CsrbCnlBND JIrg== X-Gm-Message-State: APjAAAVHgILGn0VceD8hiS5hNcLRjiX4mzPG08NsZ+gTSkbhHhwi7WcT 1krZNbJ8Olbq6VEZAB9OZ0G54CQRQaisylK4eSw= X-Received: by 2002:a63:d846:: with SMTP id k6mr31013518pgj.378.1569946884027; Tue, 01 Oct 2019 09:21:24 -0700 (PDT) Date: Tue, 1 Oct 2019 09:21:21 -0700 In-Reply-To: <20191001104253.fci7s3sn5ov3h56d@willie-the-truck> Message-Id: <20191001162121.67109-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <20191001104253.fci7s3sn5ov3h56d@willie-the-truck> X-Mailer: git-send-email 2.23.0.444.g18eeb5a265-goog Subject: Re: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly" From: Nick Desaulniers To: will@kernel.org Cc: arnd@arndb.de, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, nsaenzjulienne@suse.de, torvalds@linux-foundation.org, yamada.masahiro@socionext.com, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So you'd prefer I do something like the diff below? Yes, I find that diff preferable. Use __always_inline only when absolutely necessary. Even then, it sounds like this is a workaround for one compiler, so it should probably also have a comment. (I don't mind changing this for all compilers).