Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 01 Oct 2019 09:24:55 -0700 (PDT)
Message-Id: <20191001.092455.1322622179723053160.davem@davemloft.net>
To:     arnd@arndb.de
Cc:     snelson@pensando.io, drivers@pensando.io, krzk@kernel.org,
        leon@kernel.org, kvalo@codeaurora.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ionic: select CONFIG_NET_DEVLINK
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191001142151.1206987-1-arnd@arndb.de>
References: <20191001142151.1206987-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue,  1 Oct 2019 16:21:40 +0200

> When no other driver selects the devlink library code, ionic
> produces a link failure:
> 
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
> ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc'
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register':
> ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'
> 
> Add the same 'select' statement that the other drivers use here.
> 
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.