Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8576012ybn;
        Tue, 1 Oct 2019 10:03:08 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzUKpPCV7p1+Knee018HX/5AoHdawTOgxoG/2bgP1XtC5LTZTOk0q3+RpW9FW81WjfCjrjU
X-Received: by 2002:a50:e718:: with SMTP id a24mr26951089edn.289.1569949388685;
        Tue, 01 Oct 2019 10:03:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1569949388; cv=none;
        d=google.com; s=arc-20160816;
        b=Wa0zI5d1OmL9VjvE8vUhY7K78q5vanj/V/PCltBtKFTWB+qcySrtKFDyYBl+klWVk9
         b+aVgmOvqgxRVJOwsTkYlHUXVWwPSTBawWgFIiXv2l66lxvag5nKY+UeMa4GCADUoCaj
         nHDIa17ugcA4nHWFprMjoqG0RfMlNOBfLr9MdbwkL+dTF1JPsZJiRI8M2R9j/dWxAJVx
         JpJEoKTeL++xFmeoxJ3X5nYryuIT2dVp2eRZ+/Y2RrFldRcbF4oA8RuvvnnSt2wWmw2x
         Bl3ivEK/iQK187H8vG9zd8qOAKJZfJ9+zVAhEDwe6YDc+pU4WrWT1cjVrc0OnEumhXpD
         pl1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=r/649Y5fENjD6Gy5AsKn2eMrVKXkhwPmSi1UmmYEEnY=;
        b=q1I/SjpK1LCBPC8XbK6eI71PkAslDE4nmdZvnaIY1a+3RfTtmrNz+s+NC3DJi1y2f2
         MePU2+kN2xmz8yY2hjhV7nme7fD+y27KP6NGOMyU36sWYCRErJEUtRHDzgcZbVFsoTwQ
         6sClysRRS0ek4eQZ607a8a4IJwUwLkWpfnOy/mKDc8w+MlSUIoC//eMEcAkD70C/bQvB
         CdfQD5bF+QMeV2JCHno0WNMRYAPUnvibgbG5lmtfsfTmaONXIPY3OgUkoFDkvtmjA6cg
         jFQwhmrvL/+vBaYEP0YAWbdon0/7n9+HJEmoFax9IiOKPG0r3nKxUOo4Ygxw+0xfTv78
         AH0w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id v13si9542393eds.375.2019.10.01.10.02.39;
        Tue, 01 Oct 2019 10:03:08 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732577AbfJARCh (ORCPT <rfc822;kernelgary@gmail.com>
        + 99 others); Tue, 1 Oct 2019 13:02:37 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:50000 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729383AbfJARCf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Oct 2019 13:02:35 -0400
Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 0E4B1154ECD6A;
        Tue,  1 Oct 2019 10:02:34 -0700 (PDT)
Date:   Tue, 01 Oct 2019 10:02:33 -0700 (PDT)
Message-Id: <20191001.100233.2002881947003652758.davem@davemloft.net>
To:     wenyang@linux.alibaba.com
Cc:     alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
        xlpang@linux.alibaba.com, zhiche.yy@alibaba-inc.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mscc: ocelot: add missing of_node_put after
 calling of_get_child_by_name
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190929065424.2437-1-wenyang@linux.alibaba.com>
References: <20190929065424.2437-1-wenyang@linux.alibaba.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 10:02:34 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wen Yang <wenyang@linux.alibaba.com>
Date: Sun, 29 Sep 2019 14:54:24 +0800

> of_node_put needs to be called when the device node which is got
> from of_get_child_by_name finished using.
> In both cases of success and failure, we need to release 'ports',
> so clean up the code using goto.
> 
> fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
> Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>

Applied.