Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8577452ybn; Tue, 1 Oct 2019 10:04:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLMEca9qYumET2cVIjzR9fDYKaaGex4P9s32j56uZMSS1DuM/GdOkUwKqZEVwSUT/l6618 X-Received: by 2002:a17:906:80d9:: with SMTP id a25mr25222549ejx.222.1569949454425; Tue, 01 Oct 2019 10:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569949454; cv=none; d=google.com; s=arc-20160816; b=ZXFB2i07KspU/1L9qKOnANYGCkaHiGGXb92UoCL8darC0cbmadSI3UYIozVs1G3jKf bFhuRfHiHWtqec+8AIDYOyYIg0VRP3I3ipUNZHs9vUjYs0SKZyrjaMZGNemEieV0xEiz YJ2uBxz0x+mw/b1MkRaC69HpjnYMdwON/4gstE4dHpsH1qpchv+ntOtPMbZcAKYpa96J XsMmYTRjShBKeobCyvUvRYRr4UUeozHRM9DgmWEwwWdWMuDIIvo4bwYRp3jbh3+ydsRi Y9c+p+aF/0/nhnmF9MJQc6G3SXSVPxvjZlubEapSsUEl0sTH4KgzQpOJ3LFolytdi6E8 pXIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=YsZo8BrierdPDFFNsXIH1Q0ojQOC9e3fxi9juQ22cDk=; b=YOrm2zNmzw2YX6osT4s/W0WtcLvKkMezSYDyN2A1woe1HAGnfXVxRjtblQEXDtgWJi lWZsE61dKYJH8KgVov0EyoC1Dcgdv2nPinMAXhRMAc+qP1OiwAbupurxhuFhlqELQc7s zHnRbxep5M5l0+kz49fMLf8u4DiKCOQCwGLfj+sM65+9klcSD6aH7nunqg2/m4snalMQ Za01Mv7955jlHDS7hm2PMmbNZ8fpE8KIEPC2FfWuDdVh+HAwsqxkfgKZXj7ikijP4DQh 8hwptFGnKNhMZ9XIa4H7lz6rzEs17kXVX/eJqm+1OjY4ObieiDGnK00ghh7rSAALSIWx F5xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si9489976edx.223.2019.10.01.10.03.49; Tue, 01 Oct 2019 10:04:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732542AbfJARDo (ORCPT + 99 others); Tue, 1 Oct 2019 13:03:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50032 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731999AbfJARDm (ORCPT ); Tue, 1 Oct 2019 13:03:42 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0B1D8154F05ED; Tue, 1 Oct 2019 10:03:42 -0700 (PDT) Date: Tue, 01 Oct 2019 10:03:41 -0700 (PDT) Message-Id: <20191001.100341.1797056721948216269.davem@davemloft.net> To: wenyang@linux.alibaba.com Cc: linus.walleij@linaro.org, xlpang@linux.alibaba.com, zhiche.yy@alibaba-inc.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name From: David Miller In-Reply-To: <20190929070047.2515-1-wenyang@linux.alibaba.com> References: <20190929070047.2515-1-wenyang@linux.alibaba.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 10:03:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang Date: Sun, 29 Sep 2019 15:00:47 +0800 > of_node_put needs to be called when the device node which is got > from of_get_child_by_name finished using. > irq_domain_add_linear() also calls of_node_get() to increase refcount, > so irq_domain will not be affected when it is released. > > fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") > Signed-off-by: Wen Yang Please capitalize Fixes:, seriously I am very curious where did you learned to specify the fixes tag non-capitalized? Patch applied, t hanks.