Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Narendra.K@dell.com>
To:     <Mario.Limonciello@dell.com>
CC:     <ard.biesheuvel@linaro.org>, <geert@linux-m68k.org>,
        <Narendra.K@dell.com>, <linux-efi@vger.kernel.org>,
        <mingo@kernel.org>, <tglx@linutronix.de>,
        <linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
        <tanxiaofei@huawei.com>
Subject: Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to
 sysfs
Thread-Topic: [PATCH 4/5] efi: Export Runtime Configuration Interface table to
 sysfs
Thread-Index: AQHVUR9fTJBv0Z/1EU2zTW0DTQ5+k6dFbG6AgAAA2ACAAAKAgIAACpuAgAA9PgCAAE5zgA==
Date:   Tue, 1 Oct 2019 18:01:47 +0000
Message-ID: <20191001180133.GA2279@localhost.localdomain>
References: <20190812150452.27983-1-ard.biesheuvel@linaro.org>
 <20190812150452.27983-5-ard.biesheuvel@linaro.org>
 <CAMuHMdXY5UH4KhcaNVuxa8-+GN-4bjyvCd0wzPYuFBY5Ch=fNA@mail.gmail.com>
 <CAKv+Gu-KPypju6roQaVKP0DHE3aZijVVqLGwNyhiRSNqn1r6-w@mail.gmail.com>
 <CAMuHMdV9m+Dbch46cVNqtn4cyB74qgHa18Qcm=HQv7Wx1rk==w@mail.gmail.com>
 <CAKv+Gu9iLxkJgmxZR+1yvCTj6GiCDuyfN_QiGXEWBHS7uYUbfQ@mail.gmail.com>
 <8446d19dd197447a88eed580601f3c4c@AUSX13MPC105.AMER.DELL.COM>
In-Reply-To: <8446d19dd197447a88eed580601f3c4c@AUSX13MPC105.AMER.DELL.COM>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.242.75]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B3B522C075A76440ABEBBE764F1859B9@dell.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-01_08:2019-10-01,2019-10-01 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 lowpriorityscore=0 impostorscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 priorityscore=1501 adultscore=0
 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1910010146
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0
 mlxscore=0 priorityscore=1501 adultscore=0 clxscore=1011 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000
 definitions=main-1910010146
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 01, 2019 at 01:20:46PM +0000, Limonciello, Mario wrote:
[...]
> > > > > > +config EFI_RCI2_TABLE
> > > > > > +       bool "EFI Runtime Configuration Interface Table Version=
 2 Support"
> > > > > > +       help
> > > > > > +         Displays the content of the Runtime Configuration Int=
erface
> > > > > > +         Table version 2 on Dell EMC PowerEdge systems as a bi=
nary
> > > > > > +         attribute 'rci2' under /sys/firmware/efi/tables direc=
tory.
> > > > > > +
> > > > > > +         RCI2 table contains BIOS HII in XML format and is use=
d to populate
> > > > > > +         BIOS setup page in Dell EMC OpenManage Server Adminis=
trator tool.
> > > > > > +         The BIOS setup page contains BIOS tokens which can be=
 configured.
> > > > > > +
> > > > > > +         Say Y here for Dell EMC PowerEdge systems.
> > > > >
> > > > > A quick Google search tells me these are Intel Xeon.
> > > > > Are arm/arm64/ia64 variants available, too?
> > > > > If not, this should be protected by "depends on x86" ("|| COMPILE=
_TEST"?).
> > > >
> > > > The code in question is entirely architecture agnostic, and default=
s
> > > > to 'n', so I am not convinced this is needed. (It came up in the
> > > > review as well)
> > >
> > > "make oldconfig" still asks me the question on e.g. arm64, where it i=
s
> > > irrelevant, until arm64 variants of the hardware show up.
> > >
> > > So IMHO it should have "depends on X86 || COMPILE_TEST".
> > >
> >=20
> > Fair enough. I am going to send out a bunch of EFI fixes this week, so
> > I'll accept a patch that makes the change above.
>=20
> Is it really a problem to just say n?
>=20
> I think this seems like a needless change that would slow down adoption o=
f
> !x86 if Dell EMC PowerEdge systems did start going that route, especially
> when it comes to distributions that move glacially slow with picking up n=
ew
> kernel code.

Hi Ard/Geert,

Any additional thoughts here ?

--=20
With regards,
Narendra K=